Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validateHandlers not verbose enough #12

Open
KeKs0r opened this issue Jun 2, 2015 · 1 comment
Open

validateHandlers not verbose enough #12

KeKs0r opened this issue Jun 2, 2015 · 1 comment

Comments

@KeKs0r
Copy link

KeKs0r commented Jun 2, 2015

I was running into an issue where I misconfigured my handlers.

This is usually caught in: https://github.com/martyjs/marty-lib/blob/master/src/store/validateHandlers.js#L15

But since it is within a Flux.Dispatcher.dispatch, the error is caught and swallowed. I would therefore prefer it logging the error instead of throwing it.

I could also do the PR if this is agreed upon

@jhollingworth
Copy link
Contributor

Yeah, makes sense. PR away 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants