Skip to content
This repository has been archived by the owner on Apr 16, 2022. It is now read-only.

Unable to build #119

Closed
RazzM13 opened this issue Mar 27, 2018 · 4 comments
Closed

Unable to build #119

RazzM13 opened this issue Mar 27, 2018 · 4 comments
Labels

Comments

@RazzM13
Copy link
Contributor

RazzM13 commented Mar 27, 2018

I was just trying to replicate the build environment for this project and I've discovered that the project will not build.

Steps to replicate:

  1. git checkout 2c5ff5dfac7d6962a68c08ee1bd16abeb2667c4f
  2. npm install
    Output: npm_install.log
  3. npm run build
    Output: npm_build.log

Expected: The npm run build to succeed without an error and to return a 0 exit code.

@RazzM13
Copy link
Contributor Author

RazzM13 commented Mar 27, 2018

After some investigation, I believe that the fault lies with the version of the @types/colors package.

@martysweet
Copy link
Owner

@RazzM13 Yeah, I was just about to comment that.

Looks like fresh builds are working fine on CircleCI so not sure why it would be happening in your environment. Let me know what you discover!

@RazzM13
Copy link
Contributor Author

RazzM13 commented Mar 27, 2018

I believe that the core of the problem is the depedency cache system due to the fact that it checks the package.json file for changes, when perhaps it should be using package-lock.json. Therefore, the CircleCI build system might actually be using an earlier version of the @types/colors package instead of the new one that is published on npm and this of course would apply to all packages.

You can see my CircleCI failed build here.

@martysweet martysweet added the bug label Mar 27, 2018
@martysweet
Copy link
Owner

Thanks @RazzM13, the patch has now been merged into master. Will look into package-lock.json!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants