Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make peer management by PeerType more generic #2319

Closed
AureliaDolo opened this issue Feb 21, 2022 · 5 comments
Closed

make peer management by PeerType more generic #2319

AureliaDolo opened this issue Feb 21, 2022 · 5 comments

Comments

@AureliaDolo
Copy link
Contributor

see #2297
@AureliaDolo
Copy link
Contributor Author

@yvan-sraka if you have any fancy ideas :)

@yvan-sraka
Copy link
Contributor

@yvan-sraka if you have any fancy ideas :)

Do you recall the spaceship launch 🚀 code example from "Rust for Rustaceans"?!

@AureliaDolo AureliaDolo mentioned this issue Feb 21, 2022
Merged
@AureliaDolo
Copy link
Contributor Author

AureliaDolo commented Feb 21, 2022 •
edited
Loading

@yvan-sraka if you have any fancy ideas :)

Do you recall the spaceship launch rocket code example from "Rust for Rustaceans"?!

It's on my desk at home I still have to read it x) 🚲

@AurelienFT AurelienFT mentioned this issue Mar 5, 2022
Merged
@AurelienFT
Copy link
Contributor

I think we can close this now that peer are generic over an enum and there is already an issue to make it more generic with string here : #2334 ? @yvan-sraka @AureliaDolo

@github-actions
Copy link

github-actions bot commented May 8, 2022

This issue is stale! (no activity for 60 days)

@damip damip closed this as completed May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@yvan-sraka @damip @AurelienFT @AureliaDolo