You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Would there be a reason why HttpLoader on sys targets (e.g. neko) doesnt try to catch exceptions when triggering http.request() and pipe it through the loaderFail signal?
I don't think there's a particular reason for this, it's probably just an oversight. The only drawback would be that requests would fail silently unless you had a listener, but given that is the behaviour elsewhere I guess that's ok.
Would there be a reason why HttpLoader on sys targets (e.g. neko) doesnt try to catch exceptions when triggering
http.request()
and pipe it through the loaderFail signal?https://github.com/massiveinteractive/mloader/blob/master/src/mloader/HttpLoader.hx#L226
Other targets catch exceptions at this location correctly (e.g. js) - https://github.com/massiveinteractive/mloader/blob/master/src/mloader/HttpLoader.hx#L237
The text was updated successfully, but these errors were encountered: