Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

Commit

Permalink
fix(scripts): Make minor fixes to release scripts (and docs) (#164)
Browse files Browse the repository at this point in the history
- Change wording in pre-release script to omit info regarding committing
  a changelog. This is done within a post-release step.
- Make scripts/post-release executable
- Add a note about adding the correct publishConfig to new packages so
  that lerna can auto-published scoped packages to npm

[ci skip]
  • Loading branch information
traviskaufman authored Jan 10, 2017
1 parent 66c7c42 commit 9ba020c
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 1 deletion.
10 changes: 10 additions & 0 deletions docs/authoring-components.md
Original file line number Diff line number Diff line change
Expand Up @@ -484,6 +484,16 @@ demos
When contributing a new component, we encourage you to look at existing components to get a better
sense of our conventions. Your new component should "blend in" with all existing components.

Additionally, all new components require the following within their `package.json`:

```
"publishConfig": {
"access": "public"
}
```

This is needed so that lerna will be able to automatically publish new scoped packages.

### License Stanzas

We are required to put the following at the _top_ of _every source code file_, including tests,
Expand Down
Empty file modified scripts/post-release.sh
100644 → 100755
Empty file.
2 changes: 1 addition & 1 deletion scripts/pre-release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ log "Determining package versions..."
node scripts/determine-pkg-versions.js
echo ""

log "Pre-release steps done! You should now commit the changelog and then run " \
log "Pre-release steps done! You should now run " \
"\$(npm bin)/lerna publish, followed by ./scripts/post-release.sh"
log "Please use the package versions specified above to increment the different package versions " \
"When prompted by lerna. Or, override those versions if need be."
Expand Down

0 comments on commit 9ba020c

Please sign in to comment.