From d551dfde9dd377e7ca593565519ca49abd559d29 Mon Sep 17 00:00:00 2001 From: Patty RoDee Date: Thu, 27 Jun 2019 12:21:40 -0700 Subject: [PATCH] fix(menu): Vertically center the group icon (#4862) --- packages/mdc-menu/_mixins.scss | 3 +++ test/screenshot/golden.json | 12 ++++++------ 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/packages/mdc-menu/_mixins.scss b/packages/mdc-menu/_mixins.scss index 7ea3c28f602..eacfd32cec7 100644 --- a/packages/mdc-menu/_mixins.scss +++ b/packages/mdc-menu/_mixins.scss @@ -107,6 +107,9 @@ display: none; position: absolute; + // IE11 requires the icon to be vertically centered due to its absolute positioning + top: 50%; + transform: translateY(-50%); } } } diff --git a/test/screenshot/golden.json b/test/screenshot/golden.json index 9ea7aee0f69..c92685dd794 100644 --- a/test/screenshot/golden.json +++ b/test/screenshot/golden.json @@ -792,27 +792,27 @@ } }, "spec/mdc-menu/classes/menu-selection-group-only.html": { - "public_url": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/05/10/14_25_41_111/spec/mdc-menu/classes/menu-selection-group-only.html?utm_source=golden_json", + "public_url": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/06/27/18_48_56_264/spec/mdc-menu/classes/menu-selection-group-only.html?utm_source=golden_json", "screenshots": { "desktop_windows_chrome@latest": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/05/10/14_25_41_111/spec/mdc-menu/classes/menu-selection-group-only.html.windows_chrome_74.png", "desktop_windows_firefox@latest": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/03/19/17_12_22_925/spec/mdc-menu/classes/menu-selection-group-only.html.windows_firefox_65.png", - "desktop_windows_ie@11": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/03/19/17_12_22_925/spec/mdc-menu/classes/menu-selection-group-only.html.windows_ie_11.png" + "desktop_windows_ie@11": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/06/27/18_48_56_264/spec/mdc-menu/classes/menu-selection-group-only.html.windows_ie_11.png" } }, "spec/mdc-menu/classes/menu-selection-group.html": { - "public_url": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/05/10/14_25_41_111/spec/mdc-menu/classes/menu-selection-group.html?utm_source=golden_json", + "public_url": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/06/27/18_48_56_264/spec/mdc-menu/classes/menu-selection-group.html?utm_source=golden_json", "screenshots": { "desktop_windows_chrome@latest": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/05/10/14_25_41_111/spec/mdc-menu/classes/menu-selection-group.html.windows_chrome_74.png", "desktop_windows_firefox@latest": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/03/15/18_35_08_782/spec/mdc-menu/classes/menu-selection-group.html.windows_firefox_65.png", - "desktop_windows_ie@11": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/03/15/18_35_08_782/spec/mdc-menu/classes/menu-selection-group.html.windows_ie_11.png" + "desktop_windows_ie@11": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/06/27/18_48_56_264/spec/mdc-menu/classes/menu-selection-group.html.windows_ie_11.png" } }, "spec/mdc-menu/classes/multiple-menu-selection-group.html": { - "public_url": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/06/12/17_35_21_026/spec/mdc-menu/classes/multiple-menu-selection-group.html?utm_source=golden_json", + "public_url": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/06/27/18_48_56_264/spec/mdc-menu/classes/multiple-menu-selection-group.html?utm_source=golden_json", "screenshots": { "desktop_windows_chrome@latest": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/06/12/17_35_21_026/spec/mdc-menu/classes/multiple-menu-selection-group.html.windows_chrome_75.png", "desktop_windows_firefox@latest": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/06/12/17_35_21_026/spec/mdc-menu/classes/multiple-menu-selection-group.html.windows_firefox_67.png", - "desktop_windows_ie@11": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/06/12/17_35_21_026/spec/mdc-menu/classes/multiple-menu-selection-group.html.windows_ie_11.png" + "desktop_windows_ie@11": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/06/27/18_48_56_264/spec/mdc-menu/classes/multiple-menu-selection-group.html.windows_ie_11.png" } }, "spec/mdc-menu/issues/4025.html": {