Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

feat(text-field): Expand the helper text foundation #1955

Merged
merged 6 commits into from
Jan 16, 2018

Conversation

bwobrien
Copy link
Contributor

Adds the ability to dynamically set whether the helper text is persistent or whether it acts as a validation message.

@codecov-io
Copy link

codecov-io commented Jan 13, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@2c92827). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1955   +/-   ##
=========================================
  Coverage          ?   99.43%           
=========================================
  Files             ?       84           
  Lines             ?     3718           
  Branches          ?      486           
=========================================
  Hits              ?     3697           
  Misses            ?       21           
  Partials          ?        0
Impacted Files Coverage Δ
packages/mdc-textfield/helper-text/foundation.js 94.59% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c92827...a40c8f6. Read the comment docs.

Copy link
Contributor

@lynnmercier lynnmercier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Does this relate to #1590? Maybe you can update that issue with more information from design?

@lynnmercier lynnmercier self-assigned this Jan 16, 2018
Copy link
Contributor Author

@bwobrien bwobrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this does not change behavior as described in issue #1590. I will ping design about that one.

@bwobrien bwobrien merged commit 468942b into master Jan 16, 2018
@bwobrien bwobrien deleted the feat/text-field/helper-text-foundation branch January 16, 2018 21:26
@sidot3291 sidot3291 mentioned this pull request Jan 24, 2018
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants