Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

Fix padding on buttons #2400

Closed
aprigogin opened this issue Mar 14, 2018 · 1 comment
Closed

Fix padding on buttons #2400

aprigogin opened this issue Mar 14, 2018 · 1 comment
Assignees

Comments

@aprigogin
Copy link
Contributor

Currently horizontal padding on buttons is not customizable, that needs to change.

@lynnmercier
Copy link
Contributor

lynnmercier commented Mar 19, 2018

After much discussion

  • The icon-less text button (not contained) needs 8px padding on each side (currently it is 16px)
  • The contained button with an icon should have 12px padding to the left of the icon, 8px padding between the icon and the text, and 16px padding to the right of the text (right now it is 16px, 8ish, 16px)
  • The contained button with an icon should handle RTL by flipping the icon to the right side, and all appropriate padding should also flip
  • The text button with an icon needs an audit for its padding (not sure if it should be closer to the icon-less text button, or closer to the contained button with an icon)
  • The text button with an icon should also handle RTL

Follow up PRs might add a Sass mixin to customize the horizontal padding...but we'll do the above items first

@lynnmercier lynnmercier changed the title Horizontal padding should be customizable on buttons. Fix padding on buttons Mar 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants