This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
fix(ripple): Re-flow logic to avoid crashing Edge #2542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2542 +/- ##
==========================================
+ Coverage 98.62% 98.62% +<.01%
==========================================
Files 104 104
Lines 4226 4233 +7
Branches 530 533 +3
==========================================
+ Hits 4168 4175 +7
Misses 58 58
Continue to review full report at Codecov.
|
kfranqueiro
force-pushed
the
fix/ripple-edge-explosions
branch
from
7d25012 to
e0c4d92
Compare
packages/mdc-ripple/foundation.js
Outdated
| // Reset array on next frame after the current event has had a chance to bubble to prevent ancestor ripples | ||
| activatedTargets = []; | ||
|
|
||
| if (!activationState.wasElementMadeActive && e && e.type === 'keydown' && (e.key === ' ' || e.keyCode === 32)) { |
There was a problem hiding this comment.
I think we can remove e && e.type === 'keydown' from this statement. The only way activationState.wasElementMadeActive === false is because (e && e.type == 'keydown') === true.
There was a problem hiding this comment.
I was a bit reluctant to assume e is defined here, but confirmed our unit tests will catch if this assumption ever becomes false.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2241.
We currently have a
requestAnimationFramecall to delay a frame before checking whether the element matches the:activeselector, to work around issues in Chrome and Firefox. This delay causes the crash in Edge when a submit button is interacted with.Given that the two problems are mutually exclusive in terms of affected browsers, this means we can forego the
requestAnimationFramedelay in Edge, and avoid the crash.