fix(floating-label): Update transition durations #2590
Conversation
BREAKING CHANGE: Removes the (undocumented) mdc-floating-label-transition function
| @@ -53,11 +55,9 @@ | |||
| .mdc-notched-outline__path { | |||
There was a problem hiding this comment.
Not sure if you want to change it here or another PR, but line 50 needs to be updated: change opacity 100ms ease to use the new duration variable and standard curve timing.
Also include a transition for border-color for the transition on hover.
There was a problem hiding this comment.
In the .mdc-notched-outline__idle selector (GitHub won't let me comment there)
There was a problem hiding this comment.
I hadn't touched this because I was suspecting it was intentionally set so that there isn't still visibly a line when the label text is moving into the gap.
100ms is significantly shorter than the other values of 180 / 260 elsewhere that I replaced, and is still shorter than the new value I'm replacing it with (150).
I can change it, but I'm not sure that changing the duration in particular is a good idea?
There was a problem hiding this comment.
I updated the branch with all of the suggested changes. Given the brevity of the overall duration, this seems like it might actually be fine (and even if I slow it down in dev tools it still doesn't seem like the half-faded line and the text don't end up intersecting too badly).
As much as I'd like to avoid transitioning on non-compositable properties, adding border-color fixes another issue I'd noticed, so thanks for pointing that out.
Codecov Report
@@ Coverage Diff @@
## master #2590 +/- ##
=======================================
Coverage 98.68% 98.68%
=======================================
Files 98 98
Lines 4198 4198
Branches 533 533
=======================================
Hits 4143 4143
Misses 55 55Continue to review full report at Codecov.
|
Fixes #2561.
Also fixes notched-outline transition durations to match, since both occur at the same time in outlined text fields.
BREAKING CHANGE: Removes the (undocumented) mdc-floating-label-transition function