This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
fix(ripple): Fix missing dependency #2795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickrodee
suggested changes
May 24, 2018
packages/mdc-ripple/package.json
Outdated
| @@ -15,6 +15,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@material/base": "^0.35.0", | |||
| "@material/theme": "^0.35.0" | |||
| "@material/theme": "^0.35.0", | |||
| "@material/animation": "^0.35.0" | |||
There was a problem hiding this comment.
This should be 0.34.0. We haven't released 0.35.0 of animation yet.
There was a problem hiding this comment.
That's why the CI tests were failing, too.
…13' into fix_mdc_list_missing_dep_issue2713
Codecov Report
@@ Coverage Diff @@
## master #2795 +/- ##
=======================================
Coverage 98.48% 98.48%
=======================================
Files 98 98
Lines 4232 4232
Branches 538 538
=======================================
Hits 4168 4168
Misses 64 64Continue to review full report at Codecov.
|
patrickrodee
approved these changes
May 24, 2018
…13' into fix_mdc_list_missing_dep_issue2713
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2713