Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

fix(dialog): Fix Typography version #2821

Conversation

yezhi780625
Copy link
Contributor

@yezhi780625 yezhi780625 commented May 25, 2018

It uses legacy @material/typography which is incompatible with
other material components.

Fixes #2820

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@yezhi780625
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

It uses legacy @material/typography which is incompatible with
other material components.
@yezhi780625 yezhi780625 force-pushed the fix_mdc_dialog_package_json branch from 508b66a to de2c2e8 Compare May 25, 2018 04:40
@googlebot
Copy link

CLAs look good, thanks!

@kfranqueiro
Copy link
Contributor

Yikes. Thanks for catching this! I was indeed able to repro failure compiling Sass when installing @material/dialog and its listed dependencies alone, and it works when updating typography.

@kfranqueiro kfranqueiro merged commit e793a56 into material-components:master May 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants