This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
feat(chips): Expose method to begin chip exit animation #2845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfranqueiro
suggested changes
May 31, 2018
test/unit/mdc-chips/mdc-chip.test.js
Outdated
| @@ -202,3 +202,9 @@ test('#isSelected proxies to foundation', () => { | |||
| component.isSelected(); | |||
| td.verify(mockFoundation.isSelected()); | |||
| }); | |||
|
|
|||
| test('#beginExit adds `mdc-chip--exit` class', () => { | |||
There was a problem hiding this comment.
Reuse constant in test description and assertion
demos/chips.html
Outdated
| @@ -281,8 +285,17 @@ <h2>Custom theme</h2> | |||
| root && inputChipSetEl.removeChild(root); | |||
| } | |||
|
|
|||
| function deleteLastChip(evt) { | |||
| if (evt.type === 'click' || evt.key === 'Enter' || evt.keyCode === 13) { | |||
There was a problem hiding this comment.
This if is unnecessary; this function is only used in response to click which already triggers on enter/space for buttons.
Codecov Report
@@ Coverage Diff @@
## master #2845 +/- ##
==========================================
+ Coverage 98.39% 98.39% +<.01%
==========================================
Files 98 98
Lines 4182 4184 +2
Branches 532 532
==========================================
+ Hits 4115 4117 +2
Misses 67 67
Continue to review full report at Codecov.
|
kfranqueiro
approved these changes
May 31, 2018
demos/chips.html
Outdated
| @@ -281,8 +285,15 @@ <h2>Custom theme</h2> | |||
| root && inputChipSetEl.removeChild(root); | |||
| } | |||
|
|
|||
| function deleteLastChip(evt) { | |||
There was a problem hiding this comment.
Nit: evt is unused and can be omitted
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary for users to allow deleting a chip without interacting with the trailing remove icon. A common use case of this is deleting the last chip by pressing the backspace key in an input.
The exit animation shrinks the chip until it's invisible. Once the animation finishes, the
MDCChip:removalevent will be fired to actually remove the chip from the page.