Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

fix(text-field): Hide extraneous border in FF in HC mode. #2931

Merged
merged 4 commits into from
Jun 14, 2018

Conversation

aprigogin
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Jun 13, 2018

Codecov Report

Merging #2931 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2931   +/-   ##
======================================
  Coverage    98.3%   98.3%           
======================================
  Files         101     101           
  Lines        4363    4363           
  Branches      563     563           
======================================
  Hits         4289    4289           
  Misses         74      74

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1da9cc5...21c483f. Read the comment docs.

Copy link
Contributor

@acdvorak acdvorak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just add a short comment explaining why !important is needed here?

Something along the lines of:

border: none !important; // Needed for Firefox on Windows in high contrast mode

Otherwise LGTM!

@aprigogin aprigogin merged commit 418868a into master Jun 14, 2018
@aprigogin aprigogin deleted the fix/textfield/highcontrastmode branch June 14, 2018 22:05
kfranqueiro pushed a commit that referenced this pull request Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants