refactor(chips): Register handlers in component instead of foundation #3146
Conversation
|
Whoops, nice catch @kfranqueiro ! |
Codecov Report
@@ Coverage Diff @@
## master #3146 +/- ##
==========================================
- Coverage 98.31% 98.13% -0.19%
==========================================
Files 101 101
Lines 4454 4444 -10
Branches 585 585
==========================================
- Hits 4379 4361 -18
- Misses 75 83 +8
Continue to review full report at Codecov.
|
packages/mdc-chips/chip/index.js
Outdated
| this.handleTransitionEnd_ = (evt) => this.foundation_.handleTransitionEnd(evt); | ||
| this.handleTrailingIconInteraction_ = (evt) => this.foundation_.handleTrailingIconInteraction(evt); | ||
|
|
||
| ['click', 'keydown'].forEach((evtType) => { |
There was a problem hiding this comment.
I think making this array and the one below into variables will read better, and then you can share it in the destroy.
There was a problem hiding this comment.
Done! I'm not sure why we omitted touch events from the first array...so I added them in and used the same array for chip interaction and trailing icon interaction.
There was a problem hiding this comment.
I'm not sure why we omitted touch events from the first array
Maybe because the code in handleInteraction is a no-op for anything besides click or keyboard events anyway? I don't think adding touch events will be harmful but they'll also never do anything.
There was a problem hiding this comment.
Oh good point. The touch events are also a no-op in handleTrailingIconInteraction, so I'm just gonna remove them altogether.
|
🤖 Beep boop! Screenshot test reportCommit 7f3b794 vs. No diffs! 💯🎉 |
|
🤖 Beep boop! Screenshot test reportCommit 4773a74 vs. No diffs! 💯🎉 |
Part of #2813