Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

feat(tab-bar): Launch tab, tab indicator, tab scroller, tab bar #3252

Merged
merged 3 commits into from
Jul 27, 2018

Conversation

patrickrodee
Copy link
Contributor

@patrickrodee patrickrodee commented Jul 27, 2018

Release new MDCTab, MDCTabIndicator, MDCTabScroller, and MDCTabBar.

BREAKING CHANGE: mdc-tabs is deprecated and no longer bundled in the material-components-web package. You are encouraged to use the new mdc-tab-bar and related packages instead.

@mdc-web-bot
Copy link
Collaborator

All 140 screenshot tests passed for commit d7af258 vs. master! 💯🎉

@codecov-io
Copy link

codecov-io commented Jul 27, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@19724f1). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3252   +/-   ##
=========================================
  Coverage          ?   98.35%           
=========================================
  Files             ?      120           
  Lines             ?     5118           
  Branches          ?      638           
=========================================
  Hits              ?     5034           
  Misses            ?       84           
  Partials          ?        0
Impacted Files Coverage Δ
packages/mdc-tab/constants.js 100% <ø> (ø)
packages/mdc-tab-scroller/rtl-default-scroller.js 100% <100%> (ø)
packages/mdc-tab-bar/foundation.js 100% <100%> (ø)
packages/mdc-tab-indicator/sliding-foundation.js 100% <100%> (ø)
packages/mdc-tab-bar/index.js 100% <100%> (ø)
packages/mdc-tab-indicator/foundation.js 100% <100%> (ø)
packages/mdc-tab/index.js 100% <100%> (ø)
packages/mdc-tab/foundation.js 100% <100%> (ø)
packages/mdc-tab-scroller/rtl-negative-scroller.js 100% <100%> (ø)
packages/mdc-tab-scroller/rtl-scroller.js 100% <100%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19724f1...f37cb41. Read the comment docs.

@mdc-web-bot
Copy link
Collaborator

All 140 screenshot tests passed for commit f37cb41 vs. master! 💯🎉

@kfranqueiro kfranqueiro changed the title feat(tab-bar): Launch tab, tab indicator, tab scroller, tab feat(tab-bar): Launch tab, tab indicator, tab scroller, tab bar Jul 27, 2018
Copy link
Contributor

@kfranqueiro kfranqueiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a breaking change note in the commit description due to the change to the material-components-web package. e.g.:

BREAKING CHANGE: mdc-tabs is deprecated and no longer bundled in the material-components-web package. You are encouraged to use the new mdc-tab-bar and related packages instead.

@patrickrodee patrickrodee merged commit 78bf4bc into master Jul 27, 2018
@jamesmfriedman jamesmfriedman mentioned this pull request Jul 30, 2018
48 tasks
@kfranqueiro kfranqueiro deleted the lets-launch-some-tabs-together branch August 1, 2018 16:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants