This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
fix(slider): Don't throw error when markup min is greater than default max #3315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If min value is greater than default max value assigment of custom range fails.
Codecov Report
@@ Coverage Diff @@
## master #3315 +/- ##
=========================================
Coverage ? 98.84%
=========================================
Files ? 127
Lines ? 5628
Branches ? 746
=========================================
Hits ? 5563
Misses ? 65
Partials ? 0
Continue to review full report at Codecov.
|
acdvorak
approved these changes
Dec 13, 2018
acdvorak
changed the title
adrianschmidt
pushed a commit
to Lundalogik/material-components-web
that referenced
this pull request
Jan 4, 2019
…t max (material-components#3315) Fixes [material-components#2269](material-components#2269) Added test for custom range triggering the issue. (cherry picked from commit 5fe0c62)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2269
Added test for custom range triggering the issue.