Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

fix(ripple): Clean deactivation timer and CSS when interrupted #3529

Merged
merged 3 commits into from
Sep 10, 2018

Conversation

kfranqueiro
Copy link
Contributor

This is analogous to #2490, except for the deactivation timer rather than the activation timer.

Fixes #3527.

@mdc-web-bot
Copy link
Collaborator

All 389 screenshot tests passed for commit b77b07e vs. master! 💯🎉

@codecov-io
Copy link

codecov-io commented Sep 6, 2018

Codecov Report

Merging #3529 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3529   +/-   ##
=======================================
  Coverage   98.41%   98.41%           
=======================================
  Files         120      120           
  Lines        5036     5036           
  Branches      620      620           
=======================================
  Hits         4956     4956           
  Misses         80       80
Impacted Files Coverage Δ
packages/mdc-ripple/foundation.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16007f1...c0f0475. Read the comment docs.

Copy link
Contributor

@williamernest williamernest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdc-web-bot
Copy link
Collaborator

All 389 screenshot tests passed for commit c0f0475 vs. master! 💯🎉

@williamernest williamernest merged commit 2eda390 into master Sep 10, 2018
@williamernest williamernest deleted the fix/ripple-clear-deactivation branch September 10, 2018 21:38
adrianschmidt pushed a commit to Lundalogik/material-components-web that referenced this pull request Sep 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants