Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

fix(theme): Declare error variables as !default #3531

Merged
merged 2 commits into from
Sep 10, 2018
Merged

fix(theme): Declare error variables as !default #3531

merged 2 commits into from
Sep 10, 2018

Conversation

mathiasschopmans
Copy link
Contributor

To allow customization SASS variables should be declared as !default

To allow customization SASS variables should be declared as `!default`
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot
Copy link

CLAs look good, thanks!

Copy link
Contributor

@williamernest williamernest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for catching and fixing this for us!

@williamernest williamernest merged commit eebdcdc into material-components:master Sep 10, 2018
@mathiasschopmans mathiasschopmans deleted the patch-1 branch September 18, 2018 12:10
@jamesmfriedman jamesmfriedman mentioned this pull request Sep 26, 2018
49 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants