Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

Dialog should detect action from ancestor of event target #3560

Closed
kfranqueiro opened this issue Sep 13, 2018 · 0 comments
Closed

Dialog should detect action from ancestor of event target #3560

kfranqueiro opened this issue Sep 13, 2018 · 0 comments
Assignees
Labels
Milestone

Comments

@kfranqueiro
Copy link
Contributor

kfranqueiro commented Sep 13, 2018

The logic landing from #3413 currently only detects actions based on event.target directly.

This means that if you have any child elements within an element that represents an action (e.g. an icon inside of a list item), interacting with that child element will not properly reflect that the action was performed.

The dialog code should use mdc-dom/ponyfill.closest (#3559) to identify an action associated with interaction events.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant