This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
fix(dialog): Conform more closely with spec #3575
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is based on the dialog-stacked-reverse branch since that already has other golden updates.
This fixes the following:
I've updated goldens, but I think it's out of sync, because the screenshot test report showed "added" chips screenshot tests which are already in master. I'll have to straighten that out after the other dialog PRs get merged.