fix(menu-surface): Fix absolute positioning for scrollX #3609
Conversation
| td.verify(mockAdapter.setPosition({left: '110px', top: '100px'})); | ||
| }); | ||
|
|
||
| testFoundation('#open in absolute position at x/y=100, fixed position, hoisted menu surface, scrollY/scrollY 10 px', |
There was a problem hiding this comment.
scrollX/scrollY?
Is there any value to having the x/y scroll tests separate for absolute but combined for fixed?
Codecov Report
@@ Coverage Diff @@
## master #3609 +/- ##
==========================================
+ Coverage 98.43% 98.46% +0.02%
==========================================
Files 120 120
Lines 5192 5197 +5
Branches 649 652 +3
==========================================
+ Hits 5111 5117 +6
+ Misses 81 80 -1
Continue to review full report at Codecov.
|
| @@ -307,52 +307,51 @@ testFoundation('#open from anchor in top right of viewport, absolute position, h | |||
| td.verify(mockAdapter.setPosition({left: '20px', top: '20px'})); | |||
| }); | |||
|
|
|||
|
|
|||
| testFoundation('#open from small anchor in top right of viewport, fixed position, scrollY 10 px', | |||
| testFoundation('#open from small anchor in top left of viewport, fixed position, scrollX/scrollY 5px/10 px', | |||
There was a problem hiding this comment.
Super nit: find replace "5px/10 px" with "5px/10px"
|
🤖 Beep boop! Screenshot test report 🚦60 screenshots changed from Details60 Changed: |
|
🤖 Beep boop! Screenshot test report 🚦60 screenshots changed from Details60 Changed: |
|
All 557 screenshot tests passed for commit 467f1b1 vs. |
|
FYI the lint error this tripped over is fixed in #3623. |
|
All 557 screenshot tests passed for commit 659c52f vs. |
|
All 557 screenshot tests passed for commit 8cb9b9e vs. |
Fixes absolute positioning cases when the body is scrolled.