Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

fix(ripple): Transition background-color to avoid flashes #3693

Merged
merged 2 commits into from
Oct 2, 2018

Conversation

kfranqueiro
Copy link
Contributor

Context: material-components/material-components-web-codelabs#66 (review)

Reproducible within MDC Web using the drawer screenshot pages or demos/list.html. (Slowing down animations to 25% or 10% helps.)

@mdc-web-bot
Copy link
Collaborator

All 581 screenshot tests passed for commit 58a3f89 vs. master! 💯🎉

Copy link
Contributor

@williamernest williamernest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdc-web-bot
Copy link
Collaborator

All 581 screenshot tests passed for commit c7eab4d vs. master! 💯🎉

@kfranqueiro kfranqueiro merged commit cbc1f95 into master Oct 2, 2018
@kfranqueiro kfranqueiro deleted the fix/ripple-transition-color branch October 2, 2018 21:53
adrianschmidt pushed a commit to Lundalogik/material-components-web that referenced this pull request Oct 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants