This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
fix(text-field): Fix textarea-shape-radius mixin behavior for input #3982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhiomkar
approved these changes
Oct 23, 2018
| const firstFocusField = document.querySelector('.mdc-text-field--focused input, .mdc-text-field--focused textarea'); | ||
| if (firstFocusField) { | ||
| // Programmatically focus to get :focus applied | ||
| firstFocusField.focus(); |
There was a problem hiding this comment.
This'll make only the first element in the demo to have focus?
There was a problem hiding this comment.
Yes. Only one element in the document can have focus at a time, but this is enough to test the textarea issue and I want to see how the screenshot tests come out to see if it can be useful for other text field pages as well.
Skipped 2 approvals due to spurious changes that need a re-run
kfranqueiro
force-pushed
the
fix/textarea-focus-shape
branch
from
d7e0c09 to
16c3a6f
Compare
|
Unfortunately, forcing focus in the screenshot tests is flake-prone, due at least in part to the blinking text cursor, so I'm leaving the screenshot tests unaltered. |
|
All 564 screenshot tests passed for commit c9b719f vs. |
|
All 564 screenshot tests passed for commit 317c0f1 vs. |
27 tasks
nshahan
pushed a commit
to angulardart/angular_components
that referenced
this pull request
Nov 12, 2018
Includes the following patched changes material-components/material-components-web#3952 material-components/material-components-web#3982 material-components/material-components-web#3992 material-components/material-components-web#3993 material-components/material-components-web#3994 PiperOrigin-RevId: 219194917
nshahan
pushed a commit
to angulardart/angular_components
that referenced
this pull request
Nov 15, 2018
Includes the following patched changes material-components/material-components-web#3952 material-components/material-components-web#3982 material-components/material-components-web#3992 material-components/material-components-web#3993 material-components/material-components-web#3994 PiperOrigin-RevId: 219194917
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a gap which can end up appearing between the inner and outer elements of the textarea DOM. The style calculations were not taking into account the new radius types (e.g.
small) and were also being skipped for single-value radius arguments.