This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
fix(list): Fix font size and placement for avatar graphic #4021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Beep boop! Screenshot test report 🚦3 screenshots changed from Details3 Changed: |
acdvorak
approved these changes
Nov 2, 2018
packages/mdc-list/mdc-list.scss
Outdated
| @@ -87,7 +87,9 @@ | |||
| @include mdc-list-item-primary-text-ink-color(text-disabled-on-background); | |||
| } | |||
|
|
|||
| .mdc-list-item__graphic { | |||
| // Extra specificity is to override .material-icons display style if used in conjunction with mdc-list-item__graphic | |||
There was a problem hiding this comment.
Would it make sense to only increase specificity for display: inline-flex?
E.g.:
.mdc-list-item__graphic {
@include mdc-list-graphic-size_(24px);
flex-shrink: 0;
align-items: center;
justify-content: center;
fill: currentColor;
}
// Extra specificity is to override .material-icons display style if used in conjunction with mdc-list-item__graphic
// stylelint-disable plugin/selector-bem-pattern
.mdc-list .mdc-list-item__graphic {
display: inline-flex;
}
// stylelint-enable plugin/selector-bem-pattern
|
🤖 Beep boop! Screenshot test report 🚦3 screenshots changed from Details3 Changed: |
|
🤖 Beep boop! Screenshot test report 🚦3 screenshots changed from Details3 Changed: |
|
🤖 Beep boop! Screenshot test report 🚦3 screenshots changed from Details3 Changed: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4007.