Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

Unpkg material components map files 404 on Safari #4077

Closed
david-j-davis opened this issue Nov 12, 2018 · 2 comments
Closed

Unpkg material components map files 404 on Safari #4077

david-j-davis opened this issue Nov 12, 2018 · 2 comments

Comments

@david-j-davis
Copy link

** PLEASE READ THIS BEFORE FILING AN ISSUE **

Bugs

What MDC Web Version are you using? 0.41.0

What browser(s) is this bug affecting? Safari

"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/12.0.1 Safari/605.1.15"

What OS are you using? MacBook Pro 2017. Version 10.13.6

What are the steps to reproduce the bug?

https://codepen.io/david-j-davis/pen/gQLzWe

I'm working with the cdn Unpkg files for my project. Open up this codepen in Safari and open up the developer console and observe that there are 404's for both the material-components-web.min.js.map and min.css.map. These two missing packages are causing my js to stop working.
screen shot 2018-11-12 at 10 44 22 am

What is the expected behavior?

These files should not 404 or there should be map files for the cdn.

@abhiomkar
Copy link
Collaborator

Thanks for reporting this issue @david-j-davis

We're generating source maps for each package in build steps, but we don't seem to deploying it to npm repository.

I quickly tested hosting this bundle with source maps properly deployed it seems to work.

I'm adding this to our tracker to include source maps when deploying.

@abhiomkar
Copy link
Collaborator

abhiomkar commented Nov 12, 2018

Also this seems to be duplicate of #2942

I'm closing this one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants