This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
fix(text-field): Don't move caret when value has not changed #4160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where the cursor on Mobile Safari will be reset to its end position any time `.setValue()` is called.
This bug also occurs with MacOS Safari |
Codecov Report
@@ Coverage Diff @@
## master #4160 +/- ##
==========================================
+ Coverage 98.5% 98.84% +0.33%
==========================================
Files 127 127
Lines 5628 5629 +1
Branches 746 747 +1
==========================================
+ Hits 5544 5564 +20
+ Misses 84 65 -19
Continue to review full report at Codecov.
|
acdvorak
changed the title
acdvorak
approved these changes
Dec 14, 2018
adrianschmidt
pushed a commit
to Lundalogik/material-components-web
that referenced
this pull request
Jan 4, 2019
…l-components#4160) This fixes an issue where the cursor on Safari will be reset to its end position any time `.setValue()` is called. (cherry picked from commit d55ca11)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the cursor on Mobile Safari will be reset to its end position any time
.setValue()is called.