Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

fix(notched-outline): fix missing shape functions import #4224

Merged
merged 2 commits into from
Jan 5, 2019
Merged

fix(notched-outline): fix missing shape functions import #4224

merged 2 commits into from
Jan 5, 2019

Conversation

abhiomkar
Copy link
Collaborator

No description provided.

@abhiomkar abhiomkar requested a review from kfranqueiro January 4, 2019 09:11
@mdc-web-bot
Copy link
Collaborator

All 754 screenshot tests passed for commit 2b4e039 vs. master! 💯🎉

kfranqueiro
kfranqueiro approved these changes Jan 4, 2019
View reviewed changes
Copy link
Contributor

@kfranqueiro kfranqueiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems technically correct, but I'm wondering if anything is actually broken because of this? shape/mixins already imports shape/functions.

@mdc-web-bot
Copy link
Collaborator

All 758 screenshot tests passed for commit df60674 vs. master! 💯🎉

@abhiomkar
Copy link
Collaborator Author

That's correct. The functions was indirectly imported from shape/mixins.
There was no error messages so far. Found this after closed PR #4223

@abhiomkar abhiomkar merged commit 96f663e into master Jan 5, 2019
@abhiomkar abhiomkar deleted the fix/notched_outline_shape_function_import branch January 5, 2019 07:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kfranqueiro kfranqueiro kfranqueiro approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abhiomkar @mdc-web-bot @kfranqueiro @googlebot