This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
fix(text-field): Reset z-index property of chrome autofill box #4232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acdvorak
approved these changes
Jan 8, 2019
acdvorak
suggested changes
Jan 8, 2019
There was a problem hiding this comment.
Some of the comments on #2802 (comment) include :hover and :focus pseudo-classes in the selector:
input:-webkit-autofill,
input:-webkit-autofill:hover,
input:-webkit-autofill:focus {
z-index: auto !important;
}Did you test hover/focus states? Are those additional selectors not necessary?
acdvorak
reviewed
Jan 8, 2019
|
All 758 screenshot tests passed for commit dca2a04 vs. |
|
Above styles are inherited to |
acdvorak
approved these changes
Jan 9, 2019
|
LGTM! Thanks for the screenshot and clarifications! |
adrianschmidt
pushed a commit
to Lundalogik/material-components-web
that referenced
this pull request
Jan 23, 2019
…ial-components#4232) Screenshot:  (cherry picked from commit e718cb2)
24 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change force reset the z-index value of chrome autofill using
-webkit-autofillCSS property to keep it behind notched outline and floating label.Screenshot:
Fixes #2802