This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
fix(MenuSurface): Corrects open animation issue #4371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The opening animation is no longer present the first time the menu opens, as seen on the MDC docs site, as well as causing issues in my React wrapper. https://material-components.github.io/material-components-web-catalog/#/component/menu
|
Well, I failed linting... if one of the maintainers could help me out with that part, I'm pretty sure this still fixes the issue. |
kfranqueiro
approved these changes
Feb 8, 2019
jgroth
pushed a commit
to Lundalogik/material-components-web
that referenced
this pull request
Mar 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The opening animation is no longer present the first time the menu opens, as seen on the MDC docs site, as well as causing issues in my React wrapper.
https://material-components.github.io/material-components-web-catalog/#/component/menu