This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
fix(chips): Flip leading icon margin when used in RTL contexts (#4379) #4380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ial-components#4379) This fixes the margin of leading icons inside Chips from being applied to the incorrect side of the icon when the Chip appears in a page with RTL writing mode.
This change corrects linting issues introduced in c83766
|
Nice catch and thanks for the PR! This is also reproducible with our screenshot test pages in RTL mode (which our screenshot test pages support, but we don't capture yet due to how much time it would add to test runs). Before fix:
After fix:
|
kfranqueiro
approved these changes
Feb 8, 2019
jgroth
pushed a commit
to Lundalogik/material-components-web
that referenced
this pull request
Mar 27, 2019
…ial-components#4380) (cherry picked from commit ea15b2f)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the margin of leading icons inside Chips from being applied to the incorrect side of the icon when the Chip appears in a page with RTL writing mode.
Fixes #4379.