This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
fix(checkbox): move checkbox ripple styles into separate mixin #4454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalerba
commented
Feb 26, 2019
mmalerba
force-pushed
the
checkbox-ripple
branch
2 times, most recently
from
03d2893 to
56f3655
Compare
mmalerba
commented
Feb 28, 2019
kfranqueiro
reviewed
Mar 6, 2019
mmalerba
force-pushed
the
checkbox-ripple
branch
from
cc2090f to
092de19
Compare
|
updated, PTAL. Should also mention that we should be sure to run screenshot tests on this one. It moves the ripple styles to after the non-ripple styles instead of intermixed. We should verify that it doesn't cause any unexpected changes |
|
Yeah, I took a look at a couple of the CSS diffs too, to make sure I could identify everything. Report came back with no changes: https://storage.googleapis.com/mdc-web-screenshot-tests/kfranqueiro/2019/03/06/17_36_49_241/report/report.html However, we don't have tests for e.g. pressed state. We'll run this against further tests internally after the current in-progress sync with the first feature-targeting changes is finished. |
kfranqueiro
approved these changes
Mar 6, 2019
adrianschmidt
pushed a commit
to Lundalogik/material-components-web
that referenced
this pull request
Mar 29, 2019
…rial-components#4454) (cherry picked from commit 720bef0)
adrianschmidt
pushed a commit
to Lundalogik/material-components-web
that referenced
this pull request
Mar 29, 2019
…rial-components#4454) (cherry picked from commit 720bef0)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.