feat(tab): Add Tab Sass mixins targeting active state colors #4522
Conversation
packages/mdc-tab/_mixins.scss
Outdated
| @@ -49,10 +49,27 @@ | |||
| @include mdc-tab-text-label-color($color); | |||
| } | |||
|
|
|||
| @mixin mdc-tab-active-text-label-color($color) { | |||
| &.mdc-tab--active .mdc-tab__text-label { | |||
There was a problem hiding this comment.
Can these mixins just do what was being done in tab-bar.scss before and reuse other mixins within &.mdc-tab--active? That way there's no risk of updating one mixin and forgetting to update these other mixins in the future.
There was a problem hiding this comment.
Do you mean omitting &.mdc-tab--active here and requiring developers to specify it themselves?
There was a problem hiding this comment.
Oh nevermind, I get it, reuse mdc-tab-text-label-color. Of course, will make the change.
|
All 627 screenshot tests passed for commit 6e88be3 vs. |
|
All 627 screenshot tests passed for commit 94087e7 vs. |
…rial-components-web into feat/tab-mixins Merge origin/master
|
All 627 screenshot tests passed for commit 8809c3e vs. |
|
All 627 screenshot tests passed for commit 14ee630 vs. |
|
All 627 screenshot tests passed for commit 4f096dd vs. |
|
All 627 screenshot tests passed for commit 65d16c9 vs. |
…l-components#4522) (cherry picked from commit 31376f7)
No description provided.