This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
fix(list): Include disabled list items in keyboard navigation and allow focus #4568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4568 +/- ##
=======================================
Coverage 99.02% 99.02%
=======================================
Files 130 130
Lines 6277 6277
Branches 820 820
=======================================
Hits 6216 6216
Misses 60 60
Partials 1 1
Continue to review full report at Codecov.
|
moog16
approved these changes
Apr 8, 2019
|
🤖 Beep boop! Screenshot test report 🚦3 screenshots changed from Details |
|
🤖 Beep boop! Screenshot test report 🚦3 screenshots changed from Details |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4561
As per ARIA practice recommendation disabled menu / list items are focusable but cannot be activated. It should only be focused but should not have other states such as activated / pressed.
Please see ARIA Menu > Keyboard Interactions & Focusability of disabled controls
BREAKING CHANGE: MDCList's
listElementscomponent API now includes disabled list items which previously returned only enabled list items.