This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
fix(text-field): Fixed asterisk color where it stays in error color even after input is resolved #4576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #4260 For some reason, the color of the asterisk was set to $mdc-text-field-error in the mdc-text-field-focused mixin. Changed that to $mdc-text-field-focused-label-color, and included the asterisk mixin to mdc-text-field-invalid.
BhavyaSingh2611
approved these changes
Apr 8, 2019
|
sorry added review by mistake as i was adding review to my fork but it got submitted here |
abhiomkar
changed the title
abhiomkar
approved these changes
Apr 12, 2019
ghost
deleted the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4260
For some reason, the color of the asterisk was set to $mdc-text-field-error in the mdc-text-field-focused mixin.
Changed that to $mdc-text-field-focused-label-color, and included the asterisk mixin to mdc-text-field-invalid.