This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
feat(checkbox): Added mixin to customize checkbox touch dimension. #4697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the top and bottom padding from the components. Remove the top and bottom margins from the button content. Button content should be center aligned. Use a <button> tag for the chip. BREAKING CHANGE: Update mdc-chip-leading-icon-margin and mdc-chip-trailing-icon-margin mixins signatures to take only left and right margin values.
…dleClick/#handleKeydown. (#4655) BREAKING CHANGE: Dialog `Foundation#handleInteraction` has been split into two methods: `#handleClick` and `#handleKeydown`.
Remove the top and bottom padding from the components. Remove the top and bottom margins from the button content. Button content should be center aligned. Use a <button> tag for the chip. BREAKING CHANGE: Update mdc-chip-leading-icon-margin and mdc-chip-trailing-icon-margin mixins signatures to take only left and right margin values.
…dleClick/#handleKeydown. (#4655) BREAKING CHANGE: Dialog `Foundation#handleInteraction` has been split into two methods: `#handleClick` and `#handleKeydown`.
…on group (#4620) BREAKING CHANGE: Replaced adapter methods getParentElement, getSelectedElementIndex with getSelectedSiblingOfItemAtIndex, isSelectableItemAtIndex.
|
This technically also fixes #4597 |
moog16
suggested changes
May 9, 2019
moog16
approved these changes
May 10, 2019
moog16
reviewed
May 13, 2019
moog16
reviewed
May 13, 2019
moog16
suggested changes
May 13, 2019
|
🤖 Beep boop! Screenshot test report 🚦6 screenshots changed from Details3 Changed:3 Added: |
|
We do not seems to have polyfill to support for..of syntax in IE11 which cases it to break in IE11. Changed it to use |
Codecov Report
@@ Coverage Diff @@
## develop #4697 +/- ##
===========================================
- Coverage 98.95% 98.95% -0.01%
===========================================
Files 129 129
Lines 6302 6298 -4
Branches 821 821
===========================================
- Hits 6236 6232 -4
Misses 65 65
Partials 1 1
Continue to review full report at Codecov.
|
|
🤖 Beep boop! Screenshot test report 🚦6 screenshots changed from Details3 Changed:3 Added: |
|
🤖 Beep boop! Screenshot test report 🚦6 screenshots changed from Details3 Changed:3 Added: |
|
🤖 Beep boop! Screenshot test report 🚦6 screenshots changed from Details3 Changed:3 Added: |
moog16
pushed a commit
that referenced
this pull request
May 28, 2019
…4697) BREAKING CHANGE: Removed `$mdc-checkbox-ui-pct` sass variable from `MDCCheckbox`
moog16
pushed a commit
that referenced
this pull request
Jun 3, 2019
…4697) BREAKING CHANGE: Removed `$mdc-checkbox-ui-pct` sass variable from `MDCCheckbox`
abhiomkar
added a commit
that referenced
this pull request
Jun 11, 2019
…4697) BREAKING CHANGE: Removed `$mdc-checkbox-ui-pct` sass variable from `MDCCheckbox`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new mixin allows customizing checkbox touch dimension. The default touch dimension is unchanged.
mdc-checkbox-touch-dimension(48px);Refs #4694
BREAKING CHANGE: Removed
$mdc-checkbox-ui-pctsass variable fromMDCCheckbox