Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

fix(tabs): Remove deprecated package mdc-tabs #4784

Merged
merged 2 commits into from
Jun 18, 2019
Merged

Conversation

moog16
Copy link
Contributor

@moog16 moog16 commented Jun 3, 2019

related #4738

Deprecating mdc-tabs. mdc-tabs, mdc-tab-bar, mdc-tab-scroller, and mdc-tab-indicator are used in its place.

BREAKING CHANGE: remove mdc-tabs package.

@codecov-io
Copy link

codecov-io commented Jun 3, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@a15fa00). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             develop   #4784   +/-   ##
=========================================
  Coverage           ?   98.9%           
=========================================
  Files              ?     120           
  Lines              ?    5825           
  Branches           ?     770           
=========================================
  Hits               ?    5761           
  Misses             ?      63           
  Partials           ?       1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a15fa00...233feae. Read the comment docs.

@moog16
Copy link
Contributor Author

moog16 commented Jun 11, 2019

blocked by #4824

Copy link
Collaborator

@abhiomkar abhiomkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide more info in PR title / description and in the commit message when you Squash & Merge.

Since this is a breaking change also add BREAKING CHANGE: tagline.

@mdc-web-bot
Copy link
Collaborator

All 690 screenshot tests passed for commit 233feae vs. develop! 💯🎉

@abhiomkar abhiomkar changed the title fix: remove tabs fix(tabs): Remove deprecated package mdc-tabs Jun 18, 2019
@moog16 moog16 merged commit 4f366a5 into develop Jun 18, 2019
@moog16 moog16 deleted the fix/remove-tabs branch June 18, 2019 21:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants