-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat: add feature targeting for styles to tab-related packages #4838
feat: add feature targeting for styles to tab-related packages #4838
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4838 +/- ##
==========================================
+ Coverage 98.97% 99.27% +0.29%
==========================================
Files 130 130
Lines 6347 6347
Branches 821 821
==========================================
+ Hits 6282 6301 +19
+ Misses 64 45 -19
Partials 1 1
Continue to review full report at Codecov.
|
d2adc78
to
571aed2
Compare
cc @mmalerba |
6da9ed5
to
b416918
Compare
@abhiomkar @mmalerba I've reworked it based on the feedback. |
Can you give a diff of the final CSS just to sanity check? Code looks good to me |
Sure, here's the before and after. The main difference is that the order of a few selectors has changed, but from what I could tell it shouldn't have an effect on the end result. Also the |
Most of the look pretty trivial, though mdc.tab.css has some significant movement (maybe that's finem just wanted to point it out: http://www.mergely.com/53ydf5dw/) |
Adds support for style feature targeting to the `tab`, `tab-bar`, `tab-indicator` and `tab-scroller` packages.
b416918
to
90a2b4a
Compare
I've reworked it based on the latest set of feedback: I got rid of the smaller private mixins and the ones that are left should have feature targets. Can you take another look @abhiomkar? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @crisbeto!
Adds support for style feature targeting to the
tab
,tab-bar
,tab-indicator
andtab-scroller
packages.