fix(checkbox): Fixed hover focus colors for unchecked checkbox #4868

abhiomkar · 2019-07-01T20:48:15Z

Description

Updated mdc-checkbox-focus-indicator mixin to allow customizing ripple color for checked checkboxes. Previously mdc-checkbox-focus-indicator use to only set color for JS disabled checkboxes.
Included mdc-checkbox-focus-indicator mixin to .mdc-checkbox class name since this mixin uses state selectors such as --selected with root class.
Updated screenshot files to include --selected class name for checked checkboxes.

test/screenshot/spec/mdc-checkbox/fixture.scss

codecov-io · 2019-07-02T19:59:08Z

Codecov Report

Merging #4868 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4868      +/-   ##
==========================================
+ Coverage   98.86%   98.88%   +0.01%     
==========================================
  Files         119      119              
  Lines        5650     5823     +173     
  Branches      749      778      +29     
==========================================
+ Hits         5586     5758     +172     
- Misses         63       64       +1     
  Partials        1        1

Impacted Files	Coverage Δ
packages/mdc-chips/chip/component.ts	`99.07% <100%> (+1.63%)`	⬆️
packages/mdc-chips/chip-set/component.ts	`97.33% <100%> (-1.08%)`	⬇️
packages/mdc-chips/chip/foundation.ts	`100% <100%> (ø)`	⬆️
packages/mdc-chips/chip-set/foundation.ts	`100% <100%> (ø)`	⬆️
packages/mdc-dialog/foundation.ts	`98.68% <0%> (-0.66%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0657504...d16ba6f. Read the comment docs.

codecov-io · 2019-07-02T19:59:08Z

Codecov Report

Merging #4868 into master will decrease coverage by 0.3%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4868      +/-   ##
==========================================
- Coverage   99.16%   98.86%   -0.31%     
==========================================
  Files         119      119              
  Lines        5650     5650              
  Branches      749      749              
==========================================
- Hits         5603     5586      -17     
- Misses         46       63      +17     
  Partials        1        1

Impacted Files	Coverage Δ
packages/mdc-radio/component.ts	`87.5% <0%> (-8.34%)`	⬇️
packages/mdc-switch/component.ts	`91.37% <0%> (-6.9%)`	⬇️
packages/mdc-ripple/util.ts	`92.68% <0%> (-4.88%)`	⬇️
packages/mdc-auto-init/index.ts	`95.83% <0%> (-4.17%)`	⬇️
packages/mdc-ripple/component.ts	`96.22% <0%> (-3.78%)`	⬇️
packages/mdc-base/component.ts	`96.42% <0%> (-3.58%)`	⬇️
packages/mdc-tab/component.ts	`95.08% <0%> (-3.28%)`	⬇️
packages/mdc-checkbox/component.ts	`95.83% <0%> (-1.05%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d393fb5...e522b7c. Read the comment docs.

googlebot · 2019-07-02T20:30:33Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

googlebot · 2019-07-02T21:12:24Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

googlebot · 2019-07-02T22:26:14Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

abhiomkar · 2019-07-03T14:09:58Z

Ready for re-review.

mdc-web-bot · 2019-07-03T14:44:20Z

🤖 Beep boop!

Screenshot test report 🚦

8 screenshots changed from master on commit 5a36ed1:

https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/07/03/14_41_34_152/report/report.html?utm_source=github&utm_medium=pr_comment

Details

8 Changed:

moog16

LGTM

Side Note - I see the secondary color flash when after animation. But I think we might already have a bug for this.

googlebot · 2019-07-08T19:06:40Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

googlebot · 2019-07-08T19:08:15Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

googlebot · 2019-07-08T19:26:08Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

mdc-web-bot · 2019-07-08T20:43:11Z

🤖 Beep boop!

Screenshot test report 🚦

9 screenshots changed from master on commit b3c7b2e:

https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/07/08/20_40_26_051/report/report.html?utm_source=github&utm_medium=pr_comment

Details

9 Changed:

mdc-web-bot · 2019-07-08T23:59:06Z

🤖 Beep boop!

Screenshot test report 🚦

9 screenshots changed from master on commit 8ee31e5:

https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/07/08/23_56_16_298/report/report.html?utm_source=github&utm_medium=pr_comment

Details

9 Changed:

mdc-web-bot · 2019-07-09T22:56:06Z

🤖 Beep boop!

Screenshot test report 🚦

9 screenshots changed from master on commit e522b7c:

https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/07/09/22_53_17_619/report/report.html?utm_source=github&utm_medium=pr_comment

Details

9 Changed:

abhiomkar requested a review from moog16 July 1, 2019 20:48

googlebot added the cla: yes label Jul 1, 2019

moog16 suggested changes Jul 1, 2019

View reviewed changes

test/screenshot/spec/mdc-checkbox/fixture.scss Outdated Show resolved Hide resolved

abhiomkar force-pushed the fix/checkbox_ripple branch from f81594d to 7bc94eb Compare July 2, 2019 19:52

abhiomkar changed the base branch from master to develop July 2, 2019 19:59

abhiomkar force-pushed the fix/checkbox_ripple branch from d16ba6f to 0145eb4 Compare July 2, 2019 20:30

googlebot added cla: no and removed cla: yes labels Jul 2, 2019

abhiomkar changed the base branch from develop to master July 2, 2019 20:30

abhiomkar added cla: yes and removed cla: no labels Jul 2, 2019

moog16 approved these changes Jul 3, 2019

View reviewed changes

abhiomkar force-pushed the fix/checkbox_ripple branch from c68d27a to b606e90 Compare July 8, 2019 18:56

abhiomkar changed the base branch from master to develop July 8, 2019 19:03

abhiomkar added 5 commits July 8, 2019 15:06

fix(checkbox): state colors

e186064

Added -ripple-color param

2194ea7

goldens and README updates

100f6f3

moved selected ripple to focus-indicator mixin

9e0fcc6

README updates

e8046e0

abhiomkar force-pushed the fix/checkbox_ripple branch from 4176292 to e8046e0 Compare July 8, 2019 19:06

abhiomkar changed the base branch from develop to master July 8, 2019 19:06

googlebot removed the cla: yes label Jul 8, 2019

googlebot added the cla: no label Jul 8, 2019

abhiomkar added the cla: yes label Jul 8, 2019

googlebot removed the cla: no label Jul 8, 2019

trigger travis

d161255

abhiomkar added 2 commits July 8, 2019 15:59

goldens

4c5ebc7

golden - 1 changed

b3c7b2e

abhiomkar added 2 commits July 8, 2019 19:41

feature target fix

8ee31e5

Merge remote-tracking branch 'origin/master' into fix/checkbox_ripple

dcefb65

abhiomkar added 2 commits July 8, 2019 20:06

Fix autofocus input flaky

400bc7f

goldens firefox

e522b7c

abhiomkar merged commit 1d8fbf5 into master Jul 10, 2019

delete-merged-branch bot deleted the fix/checkbox_ripple branch July 10, 2019 14:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(checkbox): Fixed hover focus colors for unchecked checkbox #4868

fix(checkbox): Fixed hover focus colors for unchecked checkbox #4868

abhiomkar commented Jul 1, 2019 •

edited

Loading

codecov-io commented Jul 2, 2019

codecov-io commented Jul 2, 2019 •

edited

Loading

googlebot commented Jul 2, 2019

googlebot commented Jul 2, 2019

googlebot commented Jul 2, 2019

abhiomkar commented Jul 3, 2019

mdc-web-bot commented Jul 3, 2019

8 Changed:

moog16 left a comment

googlebot commented Jul 8, 2019

googlebot commented Jul 8, 2019

googlebot commented Jul 8, 2019

mdc-web-bot commented Jul 8, 2019

9 Changed:

mdc-web-bot commented Jul 8, 2019

9 Changed:

mdc-web-bot commented Jul 9, 2019

9 Changed:

fix(checkbox): Fixed hover focus colors for unchecked checkbox #4868

fix(checkbox): Fixed hover focus colors for unchecked checkbox #4868

Conversation

abhiomkar commented Jul 1, 2019 • edited Loading

Description

codecov-io commented Jul 2, 2019

Codecov Report

codecov-io commented Jul 2, 2019 • edited Loading

Codecov Report

googlebot commented Jul 2, 2019

googlebot commented Jul 2, 2019

googlebot commented Jul 2, 2019

abhiomkar commented Jul 3, 2019

mdc-web-bot commented Jul 3, 2019

Screenshot test report 🚦

8 Changed:

moog16 left a comment

Choose a reason for hiding this comment

googlebot commented Jul 8, 2019

googlebot commented Jul 8, 2019

googlebot commented Jul 8, 2019

mdc-web-bot commented Jul 8, 2019

Screenshot test report 🚦

9 Changed:

mdc-web-bot commented Jul 8, 2019

Screenshot test report 🚦

9 Changed:

mdc-web-bot commented Jul 9, 2019

Screenshot test report 🚦

9 Changed:

abhiomkar commented Jul 1, 2019 •

edited

Loading

codecov-io commented Jul 2, 2019 •

edited

Loading