Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

fix: Use head instead of body to detect edge pseudo var bug #4982

Merged
merged 3 commits into from
Aug 14, 2019
Merged

fix: Use head instead of body to detect edge pseudo var bug #4982

merged 3 commits into from
Aug 14, 2019

Conversation

aomarks
Copy link
Contributor

@aomarks aomarks commented Aug 9, 2019

If this script is invoked in the head, then the body won't exist yet, which causes the appendChild line to throw.

I confirmed that the bug is still detected in Edge 15.15063.

If this script is invoked in the head, then the body won't exist yet,
which causes the appendChild line to throw
@aomarks aomarks changed the title Use head instead of body to detect edge pseudo var bug fix: Use head instead of body to detect edge pseudo var bug Aug 12, 2019
@codecov-io
Copy link

codecov-io commented Aug 12, 2019

Codecov Report

Merging #4982 into master will increase coverage by 0.29%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4982      +/-   ##
==========================================
+ Coverage   98.79%   99.08%   +0.29%     
==========================================
  Files         122      122              
  Lines        5817     5817              
  Branches      762      762              
==========================================
+ Hits         5747     5764      +17     
+ Misses         69       52      -17     
  Partials        1        1
Impacted Files Coverage Δ
packages/mdc-ripple/util.ts 97.56% <100%> (+4.87%) ⬆️
packages/mdc-checkbox/component.ts 96.87% <0%> (+1.04%) ⬆️
packages/mdc-tab/component.ts 98.36% <0%> (+3.27%) ⬆️
packages/mdc-base/component.ts 100% <0%> (+3.57%) ⬆️
packages/mdc-ripple/component.ts 100% <0%> (+3.77%) ⬆️
packages/mdc-auto-init/index.ts 100% <0%> (+4.16%) ⬆️
packages/mdc-switch/component.ts 98.27% <0%> (+6.89%) ⬆️
packages/mdc-radio/component.ts 95.83% <0%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a7d0aa...7447c4a. Read the comment docs.

@aomarks
Copy link
Contributor Author

aomarks commented Aug 12, 2019

@abhiomkar Should be mergeable now. Fixed the failing test (needed to add head to the mock window), and added a semantic prefix to the PR title.

@abhiomkar abhiomkar merged commit 9e87478 into material-components:master Aug 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants