-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix(rtl): Removed mdc-rtl-include check from mdc-rtl-reflexive mixin #5001
Conversation
8639524
to
41842e1
Compare
🤖 Beep boop! Screenshot test report 🚦3 screenshots changed from Details3 Changed: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the screenshots that test mdc-rtl-include == false: do you think we should be adding the RTL styles ourselves in the fixture SASS, so that they render properly? Otherwise, when we make future changes to button / text input, it won't be clear whether the screenshot diffs are legitimate.
I guess we wouldn't know if the test worked if we add back the RTL overrides. Left a note in the screenshot to mention that it intended behavior when RTL is turned off. |
41842e1
to
b63134e
Compare
Codecov Report
@@ Coverage Diff @@
## master #5001 +/- ##
=========================================
Coverage ? 98.79%
=========================================
Files ? 122
Lines ? 5830
Branches ? 763
=========================================
Hits ? 5760
Misses ? 69
Partials ? 1 Continue to review full report at Codecov.
|
812730d
to
fa64b4e
Compare
🤖 Beep boop! Screenshot test report 🚦3 screenshots changed from Details3 Changed: |
fa64b4e
to
390f1aa
Compare
🤖 Beep boop! Screenshot test report 🚦3 screenshots changed from Details3 Changed: |
mdc-rtl
mixin already covers this condition.