diff --git a/packages/mdc-top-app-bar/README.md b/packages/mdc-top-app-bar/README.md
index 9f07d8d8d4e..17b2c83099b 100644
--- a/packages/mdc-top-app-bar/README.md
+++ b/packages/mdc-top-app-bar/README.md
@@ -44,13 +44,15 @@ npm install @material/top-app-bar
```
+> NOTE: Please see note below about `mdc-icon-button` in the [Top App Bar With Action Items](#top-app-bar-with-action-items) section.
+
#### Menu Icons
We recommend using [Material Icons](https://material.io/tools/icons/) from Google Fonts:
@@ -67,6 +69,7 @@ However, you can also use SVG, [Font Awesome](https://fontawesome.com/), or any
```scss
@import "@material/top-app-bar/mdc-top-app-bar";
+@import "@material/icon-button/mdc-icon-button";
```
### JavaScript Instantiation
@@ -85,19 +88,19 @@ const topAppBar = new MDCTopAppBar(topAppBarElement);
### Top App Bar With Action Items
-Top app bars can contain action items which are placed on the side opposite the navigation icon.
+Top app bars can contain action items which are placed on the side opposite the navigation icon. You must also attach the `mdc-icon-button` class to both the `mdc-top-app-bar__navigation-icon` and the `mdc-top-app-bar__action-item` elements in order to get the correct styles applied. For further documentation on icons, please see the [mdc-icon-button docs](../mdc-icon-button/README.md).
```html
@@ -111,11 +114,11 @@ Short top app bars are top app bars that can collapse to the navigation icon sid
diff --git a/packages/mdc-top-app-bar/_mixins.scss b/packages/mdc-top-app-bar/_mixins.scss
index 20f446ade70..697476972b1 100644
--- a/packages/mdc-top-app-bar/_mixins.scss
+++ b/packages/mdc-top-app-bar/_mixins.scss
@@ -107,28 +107,3 @@
}
}
}
-
-// Applies styles to the different types of icons that can exist in top-app-bars.
-// Both .mdc-top-app-bar__icon and .mdc-top-app-bar__navigation-icon share all styles except for
-// horizontal padding.
-@mixin mdc-top-app-bar-icon_() {
- @include mdc-ripple-surface;
- @include mdc-ripple-radius-unbounded;
-
- display: flex;
- position: relative;
- flex-shrink: 0;
- align-items: center;
- justify-content: center;
- box-sizing: border-box;
- width: $mdc-top-app-bar-icon-size + $mdc-top-app-bar-icon-padding * 2;
- height: $mdc-top-app-bar-icon-size + $mdc-top-app-bar-icon-padding * 2;
- padding: $mdc-top-app-bar-icon-padding;
- border: none;
- outline: none;
- background-color: transparent;
- fill: currentColor;
- color: inherit;
- text-decoration: none;
- cursor: pointer;
-}
diff --git a/packages/mdc-top-app-bar/_variables.scss b/packages/mdc-top-app-bar/_variables.scss
index 26da01262c1..78236816f90 100644
--- a/packages/mdc-top-app-bar/_variables.scss
+++ b/packages/mdc-top-app-bar/_variables.scss
@@ -26,9 +26,6 @@ $mdc-top-app-bar-title-left-padding: 20px !default;
$mdc-top-app-bar-section-vertical-padding: 8px !default;
$mdc-top-app-bar-section-horizontal-padding: 12px !default;
-$mdc-top-app-bar-icon-padding: 12px !default;
-$mdc-top-app-bar-icon-size: 24px !default;
-
$mdc-top-app-bar-mobile-breakpoint: 599px !default;
// Default mobile styles
diff --git a/packages/mdc-top-app-bar/mdc-top-app-bar.scss b/packages/mdc-top-app-bar/mdc-top-app-bar.scss
index dcf695c9518..9287fddf149 100644
--- a/packages/mdc-top-app-bar/mdc-top-app-bar.scss
+++ b/packages/mdc-top-app-bar/mdc-top-app-bar.scss
@@ -76,11 +76,6 @@
overflow: hidden;
z-index: 1;
}
-
- &__action-item,
- &__navigation-icon {
- @include mdc-top-app-bar-icon_;
- }
}
@at-root {
diff --git a/packages/mdc-top-app-bar/package.json b/packages/mdc-top-app-bar/package.json
index 54194aad838..1803d1c8af8 100644
--- a/packages/mdc-top-app-bar/package.json
+++ b/packages/mdc-top-app-bar/package.json
@@ -22,6 +22,7 @@
"@material/animation": "^1.0.0",
"@material/base": "^1.0.0",
"@material/elevation": "^1.1.0",
+ "@material/icon-button": "^2.1.1",
"@material/ripple": "^2.1.1",
"@material/rtl": "^0.42.0",
"@material/shape": "^1.1.1",
diff --git a/test/screenshot/golden.json b/test/screenshot/golden.json
index 6b39c7cad6f..b3873d7eef1 100644
--- a/test/screenshot/golden.json
+++ b/test/screenshot/golden.json
@@ -1776,34 +1776,34 @@
}
},
"spec/mdc-top-app-bar/classes/baseline-short-collapsed-with-action-items.html": {
- "public_url": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/05/28/17_57_48_326/spec/mdc-top-app-bar/classes/baseline-short-collapsed-with-action-items.html?utm_source=golden_json",
+ "public_url": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/05/29/19_08_53_246/spec/mdc-top-app-bar/classes/baseline-short-collapsed-with-action-items.html?utm_source=golden_json",
"screenshots": {
"desktop_windows_chrome@latest": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/05/14/18_21_02_727/spec/mdc-top-app-bar/classes/baseline-short-collapsed-with-action-items.html.windows_chrome_74.png",
- "desktop_windows_firefox@latest": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/05/28/17_57_48_326/spec/mdc-top-app-bar/classes/baseline-short-collapsed-with-action-items.html.windows_firefox_66.png",
+ "desktop_windows_firefox@latest": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/05/29/19_08_53_246/spec/mdc-top-app-bar/classes/baseline-short-collapsed-with-action-items.html.windows_firefox_66.png",
"desktop_windows_ie@11": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/05/14/18_21_02_727/spec/mdc-top-app-bar/classes/baseline-short-collapsed-with-action-items.html.windows_ie_11.png"
}
},
"spec/mdc-top-app-bar/classes/baseline-short-collapsed.html": {
- "public_url": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/05/28/17_57_48_326/spec/mdc-top-app-bar/classes/baseline-short-collapsed.html?utm_source=golden_json",
+ "public_url": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/05/29/19_08_53_246/spec/mdc-top-app-bar/classes/baseline-short-collapsed.html?utm_source=golden_json",
"screenshots": {
"desktop_windows_chrome@latest": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/05/14/18_21_02_727/spec/mdc-top-app-bar/classes/baseline-short-collapsed.html.windows_chrome_74.png",
- "desktop_windows_firefox@latest": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/05/28/17_57_48_326/spec/mdc-top-app-bar/classes/baseline-short-collapsed.html.windows_firefox_66.png",
+ "desktop_windows_firefox@latest": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/05/29/19_08_53_246/spec/mdc-top-app-bar/classes/baseline-short-collapsed.html.windows_firefox_66.png",
"desktop_windows_ie@11": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/05/14/18_21_02_727/spec/mdc-top-app-bar/classes/baseline-short-collapsed.html.windows_ie_11.png"
}
},
"spec/mdc-top-app-bar/classes/baseline-short-with-action-items.html": {
- "public_url": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/05/28/17_57_48_326/spec/mdc-top-app-bar/classes/baseline-short-with-action-items.html?utm_source=golden_json",
+ "public_url": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/05/29/19_08_53_246/spec/mdc-top-app-bar/classes/baseline-short-with-action-items.html?utm_source=golden_json",
"screenshots": {
"desktop_windows_chrome@latest": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/05/14/18_21_02_727/spec/mdc-top-app-bar/classes/baseline-short-with-action-items.html.windows_chrome_74.png",
- "desktop_windows_firefox@latest": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/05/28/17_57_48_326/spec/mdc-top-app-bar/classes/baseline-short-with-action-items.html.windows_firefox_66.png",
+ "desktop_windows_firefox@latest": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/05/29/19_08_53_246/spec/mdc-top-app-bar/classes/baseline-short-with-action-items.html.windows_firefox_66.png",
"desktop_windows_ie@11": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/05/14/18_21_02_727/spec/mdc-top-app-bar/classes/baseline-short-with-action-items.html.windows_ie_11.png"
}
},
"spec/mdc-top-app-bar/classes/baseline-short.html": {
- "public_url": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/05/28/17_57_48_326/spec/mdc-top-app-bar/classes/baseline-short.html?utm_source=golden_json",
+ "public_url": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/05/29/19_08_53_246/spec/mdc-top-app-bar/classes/baseline-short.html?utm_source=golden_json",
"screenshots": {
"desktop_windows_chrome@latest": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/05/14/18_21_02_727/spec/mdc-top-app-bar/classes/baseline-short.html.windows_chrome_74.png",
- "desktop_windows_firefox@latest": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/05/28/17_57_48_326/spec/mdc-top-app-bar/classes/baseline-short.html.windows_firefox_66.png",
+ "desktop_windows_firefox@latest": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/05/29/19_08_53_246/spec/mdc-top-app-bar/classes/baseline-short.html.windows_firefox_66.png",
"desktop_windows_ie@11": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/05/14/18_21_02_727/spec/mdc-top-app-bar/classes/baseline-short.html.windows_ie_11.png"
}
},
diff --git a/test/screenshot/spec/mdc-drawer/classes/dismissible-below-top-app-bar.html b/test/screenshot/spec/mdc-drawer/classes/dismissible-below-top-app-bar.html
index bdcd91b7f82..0355295b337 100644
--- a/test/screenshot/spec/mdc-drawer/classes/dismissible-below-top-app-bar.html
+++ b/test/screenshot/spec/mdc-drawer/classes/dismissible-below-top-app-bar.html
@@ -26,10 +26,12 @@
Dismissible Drawer - MDC Web Screenshot Test
+
+
@@ -46,11 +48,11 @@
diff --git a/test/screenshot/spec/mdc-drawer/classes/dismissible.html b/test/screenshot/spec/mdc-drawer/classes/dismissible.html
index f43bb721b2a..45c283d0866 100644
--- a/test/screenshot/spec/mdc-drawer/classes/dismissible.html
+++ b/test/screenshot/spec/mdc-drawer/classes/dismissible.html
@@ -26,11 +26,12 @@
Dismissible Drawer - MDC Web Screenshot Test
+
-
+
@@ -99,11 +101,11 @@
diff --git a/test/screenshot/spec/mdc-drawer/classes/permanent.html b/test/screenshot/spec/mdc-drawer/classes/permanent.html
index 748a8c7537f..4700f38a8ac 100644
--- a/test/screenshot/spec/mdc-drawer/classes/permanent.html
+++ b/test/screenshot/spec/mdc-drawer/classes/permanent.html
@@ -26,10 +26,12 @@
Permanent Drawer - MDC Web Screenshot Test
+
+
@@ -102,7 +104,7 @@
Permanent Drawer
diff --git a/test/screenshot/spec/mdc-drawer/mixins/fill-color-accessible.html b/test/screenshot/spec/mdc-drawer/mixins/fill-color-accessible.html
index cf6a9adb773..7d17e0c100e 100644
--- a/test/screenshot/spec/mdc-drawer/mixins/fill-color-accessible.html
+++ b/test/screenshot/spec/mdc-drawer/mixins/fill-color-accessible.html
@@ -24,12 +24,13 @@
fill-color-accessible Drawer Mixin - MDC Web Screenshot Test
-
+
+
@@ -102,7 +103,7 @@
Permanent Drawer
diff --git a/test/screenshot/spec/mdc-drawer/mixins/fill-color.html b/test/screenshot/spec/mdc-drawer/mixins/fill-color.html
index 1ec2c74708c..167d4e9bdc4 100644
--- a/test/screenshot/spec/mdc-drawer/mixins/fill-color.html
+++ b/test/screenshot/spec/mdc-drawer/mixins/fill-color.html
@@ -26,10 +26,12 @@
fill-color Drawer Mixin - MDC Web Screenshot Test
+
+
@@ -102,7 +104,7 @@
Permanent Drawer
diff --git a/test/screenshot/spec/mdc-drawer/mixins/width.html b/test/screenshot/spec/mdc-drawer/mixins/width.html
index e51426d8a3a..a4db8b29571 100644
--- a/test/screenshot/spec/mdc-drawer/mixins/width.html
+++ b/test/screenshot/spec/mdc-drawer/mixins/width.html
@@ -26,10 +26,12 @@
Dismissible Drawer - MDC Web Screenshot Test
+
+
@@ -90,11 +92,11 @@
diff --git a/test/screenshot/spec/mdc-top-app-bar/classes/baseline-dense-prominent-with-action-items.html b/test/screenshot/spec/mdc-top-app-bar/classes/baseline-dense-prominent-with-action-items.html
index 36c722d29bb..3b025b0aacb 100644
--- a/test/screenshot/spec/mdc-top-app-bar/classes/baseline-dense-prominent-with-action-items.html
+++ b/test/screenshot/spec/mdc-top-app-bar/classes/baseline-dense-prominent-with-action-items.html
@@ -25,6 +25,7 @@
Baseline Top App Bar Dense Prominent w/ Action Items - MDC Web Screenshot Test
+
@@ -45,13 +46,13 @@
diff --git a/test/screenshot/spec/mdc-top-app-bar/classes/baseline-dense-prominent.html b/test/screenshot/spec/mdc-top-app-bar/classes/baseline-dense-prominent.html
index 17cf619fb86..53cca40131f 100644
--- a/test/screenshot/spec/mdc-top-app-bar/classes/baseline-dense-prominent.html
+++ b/test/screenshot/spec/mdc-top-app-bar/classes/baseline-dense-prominent.html
@@ -25,6 +25,7 @@
Baseline Top App Bar Dense Prominent - MDC Web Screenshot Test
+
@@ -45,7 +46,7 @@
diff --git a/test/screenshot/spec/mdc-top-app-bar/classes/baseline-dense-with-action-items.html b/test/screenshot/spec/mdc-top-app-bar/classes/baseline-dense-with-action-items.html
index 4a90554b174..e04829e2e6e 100644
--- a/test/screenshot/spec/mdc-top-app-bar/classes/baseline-dense-with-action-items.html
+++ b/test/screenshot/spec/mdc-top-app-bar/classes/baseline-dense-with-action-items.html
@@ -25,6 +25,7 @@
Baseline Top App Bar Dense w/ Action Items - MDC Web Screenshot Test
+
@@ -45,13 +46,13 @@
diff --git a/test/screenshot/spec/mdc-top-app-bar/classes/baseline-dense.html b/test/screenshot/spec/mdc-top-app-bar/classes/baseline-dense.html
index a49fb2009d0..356fefab0d0 100644
--- a/test/screenshot/spec/mdc-top-app-bar/classes/baseline-dense.html
+++ b/test/screenshot/spec/mdc-top-app-bar/classes/baseline-dense.html
@@ -25,6 +25,7 @@
Baseline Top App Bar Dense - MDC Web Screenshot Test
+
@@ -45,7 +46,7 @@
diff --git a/test/screenshot/spec/mdc-top-app-bar/classes/baseline-fixed-with-action-items.html b/test/screenshot/spec/mdc-top-app-bar/classes/baseline-fixed-with-action-items.html
index 22ff0029581..10b78f18ddf 100644
--- a/test/screenshot/spec/mdc-top-app-bar/classes/baseline-fixed-with-action-items.html
+++ b/test/screenshot/spec/mdc-top-app-bar/classes/baseline-fixed-with-action-items.html
@@ -25,6 +25,7 @@
Baseline Top App Bar Fixed w/ Action Items - MDC Web Screenshot Test
+
@@ -45,13 +46,13 @@
diff --git a/test/screenshot/spec/mdc-top-app-bar/classes/baseline-fixed.html b/test/screenshot/spec/mdc-top-app-bar/classes/baseline-fixed.html
index 6a22096fbed..ae2e969c604 100644
--- a/test/screenshot/spec/mdc-top-app-bar/classes/baseline-fixed.html
+++ b/test/screenshot/spec/mdc-top-app-bar/classes/baseline-fixed.html
@@ -25,6 +25,7 @@
Baseline Top App Bar Fixed - MDC Web Screenshot Test
+
@@ -45,7 +46,7 @@
diff --git a/test/screenshot/spec/mdc-top-app-bar/classes/baseline-prominent-with-action-items.html b/test/screenshot/spec/mdc-top-app-bar/classes/baseline-prominent-with-action-items.html
index 3c9481c8727..382990da72f 100644
--- a/test/screenshot/spec/mdc-top-app-bar/classes/baseline-prominent-with-action-items.html
+++ b/test/screenshot/spec/mdc-top-app-bar/classes/baseline-prominent-with-action-items.html
@@ -25,6 +25,7 @@
Baseline Top App Bar Prominent w/ Action Items - MDC Web Screenshot Test
+
@@ -45,13 +46,13 @@
diff --git a/test/screenshot/spec/mdc-top-app-bar/classes/baseline-prominent.html b/test/screenshot/spec/mdc-top-app-bar/classes/baseline-prominent.html
index 0be08d652fa..55fe56479ed 100644
--- a/test/screenshot/spec/mdc-top-app-bar/classes/baseline-prominent.html
+++ b/test/screenshot/spec/mdc-top-app-bar/classes/baseline-prominent.html
@@ -25,6 +25,7 @@
Baseline Top App Bar Prominent - MDC Web Screenshot Test
+
@@ -45,7 +46,7 @@
diff --git a/test/screenshot/spec/mdc-top-app-bar/classes/baseline-short-collapsed-with-action-items.html b/test/screenshot/spec/mdc-top-app-bar/classes/baseline-short-collapsed-with-action-items.html
index 9a4c9e3781d..3e350a002f7 100644
--- a/test/screenshot/spec/mdc-top-app-bar/classes/baseline-short-collapsed-with-action-items.html
+++ b/test/screenshot/spec/mdc-top-app-bar/classes/baseline-short-collapsed-with-action-items.html
@@ -25,6 +25,7 @@
Baseline Top App Bar Short Collapsed w/ Action Items - MDC Web Screenshot Test
+
@@ -45,11 +46,11 @@
diff --git a/test/screenshot/spec/mdc-top-app-bar/classes/baseline-short-collapsed.html b/test/screenshot/spec/mdc-top-app-bar/classes/baseline-short-collapsed.html
index 91474011cc5..c2080884a47 100644
--- a/test/screenshot/spec/mdc-top-app-bar/classes/baseline-short-collapsed.html
+++ b/test/screenshot/spec/mdc-top-app-bar/classes/baseline-short-collapsed.html
@@ -25,6 +25,7 @@
Baseline Top App Bar Short Collapsed - MDC Web Screenshot Test
+
@@ -45,7 +46,7 @@
diff --git a/test/screenshot/spec/mdc-top-app-bar/classes/baseline-short-with-action-items.html b/test/screenshot/spec/mdc-top-app-bar/classes/baseline-short-with-action-items.html
index 12763fec8e9..8d03cdd93ab 100644
--- a/test/screenshot/spec/mdc-top-app-bar/classes/baseline-short-with-action-items.html
+++ b/test/screenshot/spec/mdc-top-app-bar/classes/baseline-short-with-action-items.html
@@ -25,6 +25,7 @@
Baseline Top App Bar Short w/ Action Items - MDC Web Screenshot Test
+
@@ -45,11 +46,11 @@
diff --git a/test/screenshot/spec/mdc-top-app-bar/classes/baseline-short.html b/test/screenshot/spec/mdc-top-app-bar/classes/baseline-short.html
index 2ea29e129a1..7019a265b29 100644
--- a/test/screenshot/spec/mdc-top-app-bar/classes/baseline-short.html
+++ b/test/screenshot/spec/mdc-top-app-bar/classes/baseline-short.html
@@ -25,6 +25,7 @@
Baseline Top App Bar Short - MDC Web Screenshot Test
+
@@ -45,7 +46,7 @@
diff --git a/test/screenshot/spec/mdc-top-app-bar/classes/baseline-with-action-items.html b/test/screenshot/spec/mdc-top-app-bar/classes/baseline-with-action-items.html
index 83cdee191d5..525a9b16246 100644
--- a/test/screenshot/spec/mdc-top-app-bar/classes/baseline-with-action-items.html
+++ b/test/screenshot/spec/mdc-top-app-bar/classes/baseline-with-action-items.html
@@ -25,6 +25,7 @@
Baseline Top App Bar w/ Action Items - MDC Web Screenshot Test
+
@@ -45,13 +46,13 @@
diff --git a/test/screenshot/spec/mdc-top-app-bar/classes/baseline.html b/test/screenshot/spec/mdc-top-app-bar/classes/baseline.html
index d2d9f10687c..5add4720d55 100644
--- a/test/screenshot/spec/mdc-top-app-bar/classes/baseline.html
+++ b/test/screenshot/spec/mdc-top-app-bar/classes/baseline.html
@@ -25,6 +25,7 @@
Baseline Top App Bar - MDC Web Screenshot Test
+
@@ -45,7 +46,7 @@