Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listen to platform color changes #300

Open
ebraminio opened this issue Jun 1, 2022 · 1 comment
Open

Listen to platform color changes #300

ebraminio opened this issue Jun 1, 2022 · 1 comment
Labels
enhancement New feature or request p: dynamic_color

Comments

@ebraminio
Copy link
Contributor

ebraminio commented Jun 1, 2022

Reading from macOS and Windows color accents happened on material-foundation/material-dynamic-color-flutter#42 and material-foundation/material-dynamic-color-flutter#43 and they work fine but they aren't responsive to OS changes. There are ways to get notified about OS changes and update colorings:

What do you suggest here, to reimplement the logic here, or, make flutter engine to take those into account among their other offerings such as whether system is in dark mode. And how the Android one works, listening for onResume to reread from the platform?

@guidezpl
Copy link
Collaborator

guidezpl commented Jun 1, 2022

I'm not sure since I'm not too familiar with the engine layer. You may face some resistance for adding a feature needed by a single package, unless you can justify other uses by the framework, or if implementing this logic here is infeasible. I'd create a flutter/flutter issue and get some feedback on the Discord.

@guidezpl guidezpl added the enhancement New feature or request label Oct 6, 2022
@guidezpl guidezpl transferred this issue from material-foundation/material-dynamic-color-flutter Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request p: dynamic_color
Projects
None yet
Development

No branches or pull requests

2 participants