Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic ColorScheme does not support new color tokens #591

Closed
1 task
emmaxCreative opened this issue May 28, 2024 · 4 comments
Closed
1 task

Dynamic ColorScheme does not support new color tokens #591

emmaxCreative opened this issue May 28, 2024 · 4 comments
Labels
bug Something isn't working p: dynamic_color

Comments

@emmaxCreative
Copy link

emmaxCreative commented May 28, 2024

Package

dynamic_color

Existing issue?

What happened?

Expected vs actual result:

Expected result: dynamic colorscheme should support the new color tokens: for example surfaceContainerHigh etc

Actual result: All components of flutter that probably use the new tokens under the hood use a fallback color which results in an UI where you can se no different shades from different levels of containers. For example a card will have the same color as the scaffold background.

Steps to reproduce:

  1. install Flutter 3.22.1
  2. try to use dynamic theme

Relevant log output

Flutter (Channel stable, 3.22.1, on Microsoft Windows [Version 10.0.19045.4412], locale de-DE)
    • Flutter version 3.22.1 on channel stable at C:\flutter               
    • Upstream repository https://github.com/flutter/flutter.git           
    • Framework revision a14f74ff3a (6 days ago), 2024-05-22 11:08:21 -0500
    • Engine revision 55eae6864b                                           
    • Dart version 3.4.1                                                   
    • DevTools version 2.34.3
@emmaxCreative emmaxCreative added bug Something isn't working triage Issues that haven't been triaged labels May 28, 2024
@Henry-Hiles
Copy link

Henry-Hiles commented Jun 9, 2024

I'm not sure if you have permission but this needs the "p: dynamic_color" label.

@tmaihoff
Copy link

Running into the same issue after upgrading to Flutter 3.22.
Do you we have a timeline on this?

@purofle
Copy link

purofle commented Jun 20, 2024

Same problem on Flutter 3.22

@guidezpl guidezpl added p: dynamic_color and removed triage Issues that haven't been triaged labels Jul 2, 2024
@guidezpl
Copy link
Collaborator

guidezpl commented Jul 2, 2024

Closing as dupe of #582

@guidezpl guidezpl closed this as not planned Won't fix, can't repro, duplicate, stale Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p: dynamic_color
Projects
None yet
Development

No branches or pull requests

5 participants