-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ChemEnv integration #595
Comments
I think I will just make a pull request for the option where we only do the analysis when oxidation states are available. I will comment the other code for now. It runs at least twice as fast and should also be easier to understand for users if only one type of ChemEnv analysis is used. |
@JaGeo, just pinging you here to let you know I am debugging some builder pipeline issues which is delaying me on getting the |
@munrojm Thanks for the update! 🙂 |
@JaGeo, the builder runs well! I am able to get it completed in ~5hrs within our build pipelines. The data should be incorporated into the DB and available through the API next release. |
@munrojm Awesome! 🥳 Thank you so much! |
@munrojm If there is more documentation needed to make this available, just let me know. I am happy to help with this as well. |
@JaGeo, I appreciate the offer. Apologies again for the delay on this. This is essentially ready to go on the API side. Our initial intent was to wait to bundle this with some other data in the next DB release, but that kept getting pushed back for a number of reasons. Currently, I am working to fix up thermo data related issues. We intend to deploy again soon with to accommodate the changes. What I will do is include the ChemEnv data in that deployment so it is available next week. |
Great, thank you! |
I do have an additional question: would it be in principle possible to get a DOI for such a dataset (the whole one)? |
@JaGeo The DOIs we get from OSTI need to be matched to a landing page. Dataset contributions to core and not MPContribs don't have that, and thus we can't assign DOIs for them. @tschaume can weigh in on this in case I am getting something wrong. On another note, do you have any particular things you would like to have included as filters on the chemenv data within the API? |
@munrojm I think a filter on the environment names would be good: |
@JaGeo, feel free to try pulling the data with the latest MPRester and let me know what other changes you would like to make. We are going to be working on website integration soon. |
Thank you, @munrojm ! I will try to test it during this week! |
@munrojm, I was too curious and I added some suggestions here: materialsproject/api#771 |
As mentioned by mail, I would like to provide the ChemEnv data, @munrojm.
I am currently testing several options:
I will add run times and provide potential implementations in the form of a pull request in a next step. We should potentially test the fastest option first and then see if this is doable on your systems and potentially extend the number of compounds complexity step by step.
The text was updated successfully, but these errors were encountered: