Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VASP Input Sets: Investigate LMAXTAU #2325

Closed
mkhorton opened this issue Dec 20, 2021 · 8 comments
Closed

VASP Input Sets: Investigate LMAXTAU #2325

mkhorton opened this issue Dec 20, 2021 · 8 comments
Assignees

Comments

@mkhorton
Copy link
Member

Thanks @arosen93:

If the PAW one-center expansion of the density has component up to L, then the one-center expansion of the kinetic energy density has components up to L+2. This means that as a rule of thumb, for s-elements: LMAXTAU=2, for p: LMAXTAU=4, and for d: LMAXTAU=6. If you are willing to live with the computational costs, the default for LMAXTAU should be safe in all cases, except those involving f-elements. [emphasis mine]

via https://www.vasp.at/wiki/index.php/LMAXTAU

Will likely add appropriate logic to appropriate VASP input sets.

@mkhorton mkhorton self-assigned this Dec 20, 2021
@mkhorton
Copy link
Member Author

Notifying @rkingsbury too as likely relevant for SCAN input sets.

@Andrew-S-Rosen
Copy link
Member

Just to clarify for my own notes too: This is really only relevant if LAPSH = True.

@rkingsbury
Copy link
Contributor

Thanks @mkhorton ; if you change the SCAN sets just please make sure to check if any validation rules in the validation builder need to change (I don't think they do).

@Andrew-S-Rosen
Copy link
Member

Andrew-S-Rosen commented Jun 3, 2023

@munrojm, @janosh: We should probably consider updating this in the Atomate2 workflow......

@Andrew-S-Rosen
Copy link
Member

Andrew-S-Rosen commented Jun 4, 2023

The fix for this can ultimately be adapted from the relevant part in the Atomate2 PR: materialsproject/atomate2#362

@Andrew-S-Rosen
Copy link
Member

Andrew-S-Rosen commented Jul 24, 2023

Apparently there is plenty of ambiguity about this... https://www.vasp.at/forum/viewtopic.php?p=23038. I would lean towards closing this issue as a result. If Kresse says it's fine, then I'm inclined to believe him.

@janosh
Copy link
Member

janosh commented Jul 24, 2023

We removed the the _set_lmaxtau helper entirely in materialsproject/atomate2@75c43ba in an attempt to fix this VASP error

 -----------------------------------------------------------------------------
|                     _     ____    _    _    _____     _                     |
|                    | |   |  _ \  | |  | |  / ____|   | |                    |
|                    | |   | |_) | | |  | | | |  __    | |                    |
|                    |_|   |  _ <  | |  | | | | |_ |   |_|                    |
|                     _    | |_) | | |__| | | |__| |    _                     |
|                    (_)   |____/   \____/   \_____|   (_)                    |
|                                                                             |
|     internal error in: asa.F  at line: 479                                  |
|                                                                             |
|     internal error in YLM3LOOKUP: L or LP > LMAXCG                          |
|      L, LP, LMAXCG 7 1 6                                                    |
|                                                                             |
|     If you are not a developer, you should not encounter this problem.      |
|     Please submit a bug report.                                             |
|                                                                             |
 -----------------------------------------------------------------------------

@Andrew-S-Rosen
Copy link
Member

@janosh: Let's close this as being not needed.

@janosh janosh closed this as not planned Won't fix, can't repro, duplicate, stale Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants