Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The inappropriate warnning info for update_user_incar_settings. #4179

Closed
hongyi-zhao opened this issue Nov 17, 2024 · 3 comments
Closed

The inappropriate warnning info for update_user_incar_settings. #4179

hongyi-zhao opened this issue Nov 17, 2024 · 3 comments

Comments

@hongyi-zhao
Copy link
Contributor

hongyi-zhao commented Nov 17, 2024

When I tested an atomate2 flow, I noticed the following information:

In [7]: flow = update_user_incar_settings(flow, { 'ALGO': 'Normal', 'EDIFF': 1e-06, 'ENCUT':700})
/home/werner/.pyenv/versions/3.11.1/envs/datasci/lib/python3.11/site-packages/pymatgen/io/vasp/sets.py:288: BadInputSetWarning: Overriding the POTCAR functional is generally not recommended  as it significantly affects the results of calculations and compatibility with other calculations done with the same input set. Note that some POTCAR symbols specified in the configuration file may not be available in the selected functional.
  warnings.warn(

This is an inappropriate warning message. Because I update INCAR here, the warning is indeed related to POTCAR.

Regards,
Zhao

@QuantumChemist
Copy link
Contributor

Hey Zhao,
Could you elaborate a little bit why exactly this warning is inappropriate?

@hongyi-zhao
Copy link
Contributor Author

hongyi-zhao commented Nov 17, 2024

I mean, this warning should be triggered by something like update_user_potcar_functional instead of update_user_incar_settings.

@esoteric-ephemera
Copy link
Contributor

Can you move this over to atomate2 with a complete code snippet? I don't think this is a pymatgen issue

@hongyi-zhao hongyi-zhao changed the title The incorrect warnning info for update_user_incar_settings. The inappropriate warnning info for update_user_incar_settings. Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants