Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: 2 tests fail #736

Open
2 of 4 tasks
yurivict opened this issue Jan 6, 2025 · 1 comment · May be fixed by #742
Open
2 of 4 tasks

[Bug]: 2 tests fail #736

yurivict opened this issue Jan 6, 2025 · 1 comment · May be fixed by #742
Labels
bug

Comments

@yurivict
Copy link

yurivict commented Jan 6, 2025

Email (Optional)

No response

Version

2025.1.3

Which OS(es) are you using?

  • MacOS
  • Windows
  • Linux

What happened?

========================================================================================= FAILURES ==========================================================================================
_________________________________________________________________________________ test_install_except_hook __________________________________________________________________________________
[gw1] freebsd14 -- Python 3.11.11 /usr/local/bin/python3.11

hook_type = 'color', kwargs = {}

    def install_excepthook(hook_type: str = "color", **kwargs) -> int:
        """
        This function replaces the original python traceback with an improved
        version from Ipython. Use `color` for colourful traceback formatting,
        `verbose` for Ka-Ping Yee's "cgitb.py" version kwargs are the keyword
        arguments passed to the constructor. See IPython.core.ultratb.py for more
        info.
    
        Returns:
            0 if hook is installed successfully.
        """
        try:
>           from IPython.core import ultratb  # pylint: disable=import-outside-toplevel
E           ModuleNotFoundError: No module named 'IPython'

../stage/usr/local/lib/python3.11/site-packages/monty/dev.py:185: ModuleNotFoundError

The above exception was the direct cause of the following exception:

    def test_install_except_hook():
>       install_excepthook()

tests/test_dev.py:204: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

hook_type = 'color', kwargs = {}

    def install_excepthook(hook_type: str = "color", **kwargs) -> int:
        """
        This function replaces the original python traceback with an improved
        version from Ipython. Use `color` for colourful traceback formatting,
        `verbose` for Ka-Ping Yee's "cgitb.py" version kwargs are the keyword
        arguments passed to the constructor. See IPython.core.ultratb.py for more
        info.
    
        Returns:
            0 if hook is installed successfully.
        """
        try:
            from IPython.core import ultratb  # pylint: disable=import-outside-toplevel
        except ImportError as exc:
>           raise ImportError("Cannot install excepthook, IPython not installed") from exc
E           ImportError: Cannot install excepthook, IPython not installed

../stage/usr/local/lib/python3.11/site-packages/monty/dev.py:187: ImportError
__________________________________________________________________________ TestControlledDict.test_update_allowed ___________________________________________________________________________
[gw1] freebsd14 -- Python 3.11.11 /usr/local/bin/python3.11

self = <tests.test_collections.TestControlledDict object at 0x1b8d5fd67a50>

    def test_update_allowed(self):
        dct = ControlledDict(a=1)
        dct._allow_update = True
    
        dct["a"] = 2
        assert dct["a"] == 2
    
        dct.update({"a": 3})
        assert dct["a"] == 3
    
        # Test Iterator handling
>       dct.update(zip(["c", "d"], [11, 12]))

tests/test_collections.py:66: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = {'a': 3}, args = (<zip object at 0x1b8d63195f40>,), kwargs = {}, updates = {'c': 11, 'd': 12}, key = 'c'

    def update(self, *args, **kwargs) -> None:
        """Forbid adding or updating keys based on _allow_add and _allow_update."""
    
        updates = dict(*args, **kwargs)
        for key in updates:
            if key not in self.data and not self._allow_add:
>               raise TypeError(
                    f"Cannot add new key {key!r} using update, because add is disabled."
E                   TypeError: Cannot add new key 'c' using update, because add is disabled.

../stage/usr/local/lib/python3.11/site-packages/monty/collections.py:96: TypeError
===================================================================================== warnings summary ======================================================================================
tests/test_design_patterns.py:55
tests/test_design_patterns.py:55
tests/test_design_patterns.py:55
tests/test_design_patterns.py:55
  /usr/ports/devel/py-monty/work-py311/monty-2025.1.3/tests/test_design_patterns.py:55: PytestCollectionWarning: cannot collect test class 'TestClass' because it has a __init__ constructor (from: tests/test_design_patterns.py)
    @cached_class

tests/test_tempfile.py::TestScratchDir::test_with_copy_gzip
  /usr/ports/devel/py-monty/work-py311/stage/usr/local/lib/python3.11/site-packages/monty/tempfile.py:117: UserWarning: Both 3000_lines.txt.bz2 and 3000_lines.txt.bz2.gz exist.
    gzip_dir(self.tempdir)

tests/test_tempfile.py::TestScratchDir::test_with_copy_gzip
  /usr/ports/devel/py-monty/work-py311/stage/usr/local/lib/python3.11/site-packages/monty/tempfile.py:117: UserWarning: Both empty_file.txt and empty_file.txt.gz exist.
    gzip_dir(self.tempdir)

tests/test_tempfile.py::TestScratchDir::test_with_copy_gzip
  /usr/ports/devel/py-monty/work-py311/stage/usr/local/lib/python3.11/site-packages/monty/tempfile.py:117: UserWarning: Both test_settings.yaml and test_settings.yaml.gz exist.
    gzip_dir(self.tempdir)

tests/test_tempfile.py::TestScratchDir::test_with_copy_gzip
  /usr/ports/devel/py-monty/work-py311/stage/usr/local/lib/python3.11/site-packages/monty/tempfile.py:117: UserWarning: Both pre_scratch_text and pre_scratch_text.gz exist.
    gzip_dir(self.tempdir)

tests/test_tempfile.py::TestScratchDir::test_with_copy_gzip
  /usr/ports/devel/py-monty/work-py311/stage/usr/local/lib/python3.11/site-packages/monty/tempfile.py:117: UserWarning: Both scratch_text and scratch_text.gz exist.
    gzip_dir(self.tempdir)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

-------- coverage: platform freebsd14, python 3.11.11-final-0 --------
Name                                                                                                         Stmts   Miss Branch BrPart  Cover
----------------------------------------------------------------------------------------------------------------------------------------------
/usr/ports/devel/py-monty/work-py311/stage/usr/local/lib/python3.11/site-packages/monty/__init__.py              9      0      0      0   100%
/usr/ports/devel/py-monty/work-py311/stage/usr/local/lib/python3.11/site-packages/monty/bisect.py               36      7     16      7    69%
/usr/ports/devel/py-monty/work-py311/stage/usr/local/lib/python3.11/site-packages/monty/collections.py         115      5     30      2    95%
/usr/ports/devel/py-monty/work-py311/stage/usr/local/lib/python3.11/site-packages/monty/design_patterns.py      63      5     14      4    88%
/usr/ports/devel/py-monty/work-py311/stage/usr/local/lib/python3.11/site-packages/monty/dev.py                  77      5     24      1    92%
/usr/ports/devel/py-monty/work-py311/stage/usr/local/lib/python3.11/site-packages/monty/fnmatch.py              18      8      6      0    42%
/usr/ports/devel/py-monty/work-py311/stage/usr/local/lib/python3.11/site-packages/monty/fractions.py            22      0      8      0   100%
/usr/ports/devel/py-monty/work-py311/stage/usr/local/lib/python3.11/site-packages/monty/functools.py           112     38     38      2    61%
/usr/ports/devel/py-monty/work-py311/stage/usr/local/lib/python3.11/site-packages/monty/inspect.py              31      2     10      4    85%
/usr/ports/devel/py-monty/work-py311/stage/usr/local/lib/python3.11/site-packages/monty/io.py                  157     11     74      2    93%
/usr/ports/devel/py-monty/work-py311/stage/usr/local/lib/python3.11/site-packages/monty/itertools.py            32     15     20      1    38%
/usr/ports/devel/py-monty/work-py311/stage/usr/local/lib/python3.11/site-packages/monty/json.py                438     73    200     20    82%
/usr/ports/devel/py-monty/work-py311/stage/usr/local/lib/python3.11/site-packages/monty/logging.py              28     11      2      0    57%
/usr/ports/devel/py-monty/work-py311/stage/usr/local/lib/python3.11/site-packages/monty/math.py                  8      0      0      0   100%
/usr/ports/devel/py-monty/work-py311/stage/usr/local/lib/python3.11/site-packages/monty/msgpack.py               6      1      0      0    83%
/usr/ports/devel/py-monty/work-py311/stage/usr/local/lib/python3.11/site-packages/monty/multiprocessing.py      19      2      2      0    90%
/usr/ports/devel/py-monty/work-py311/stage/usr/local/lib/python3.11/site-packages/monty/operator.py              9      0      0      0   100%
/usr/ports/devel/py-monty/work-py311/stage/usr/local/lib/python3.11/site-packages/monty/os/__init__.py          25      0      2      0   100%
/usr/ports/devel/py-monty/work-py311/stage/usr/local/lib/python3.11/site-packages/monty/os/path.py              37      1     22      1    97%
/usr/ports/devel/py-monty/work-py311/stage/usr/local/lib/python3.11/site-packages/monty/pprint.py               53     17     14      1    70%
/usr/ports/devel/py-monty/work-py311/stage/usr/local/lib/python3.11/site-packages/monty/re.py                   19      0      8      0   100%
/usr/ports/devel/py-monty/work-py311/stage/usr/local/lib/python3.11/site-packages/monty/serialization.py        63      4     40      8    88%
/usr/ports/devel/py-monty/work-py311/stage/usr/local/lib/python3.11/site-packages/monty/shutil.py               82      1     40      1    98%
/usr/ports/devel/py-monty/work-py311/stage/usr/local/lib/python3.11/site-packages/monty/string.py               31     16      6      1    43%
/usr/ports/devel/py-monty/work-py311/stage/usr/local/lib/python3.11/site-packages/monty/subprocess.py           45      3      8      3    89%
/usr/ports/devel/py-monty/work-py311/stage/usr/local/lib/python3.11/site-packages/monty/tempfile.py             45      1     20      1    97%
/usr/ports/devel/py-monty/work-py311/stage/usr/local/lib/python3.11/site-packages/monty/termcolor.py            80     15     24      6    80%
tests/__init__.py                                                                                                7      0      0      0   100%
tests/test_bisect.py                                                                                             9      0      0      0   100%
tests/test_collections.py                                                                                      165      3      0      0    98%
tests/test_design_patterns.py                                                                                  199      2      4      0    99%
tests/test_dev.py                                                                                               90      9      0      0    90%
tests/test_fnmatch.py                                                                                            6      0      0      0   100%
tests/test_fractions.py                                                                                         10      0      0      0   100%
tests/test_functools.py                                                                                        411     27      4      2    93%
tests/test_inspect.py                                                                                           16      0      0      0   100%
tests/test_io.py                                                                                               261      2     46      2    99%
tests/test_itertools.py                                                                                          6      0      0      0   100%
tests/test_json.py                                                                                             745    116     18      0    84%
tests/test_logging.py                                                                                           11      0      0      0   100%
tests/test_math.py                                                                                               6      0      0      0   100%
tests/test_multiprocessing.py                                                                                   13      0      0      0   100%
tests/test_operator.py                                                                                           5      0      0      0   100%
tests/test_os.py                                                                                                70      0      2      0   100%
tests/test_pprint.py                                                                                            16      0      0      0   100%
tests/test_re.py                                                                                                13      0      0      0   100%
tests/test_serialization.py                                                                                     57      0      4      0   100%
tests/test_shutil.py                                                                                           154      0      6      1    99%
tests/test_string.py                                                                                             8      0      0      0   100%
tests/test_subprocess.py                                                                                        11      0      0      0   100%
tests/test_tempfile.py                                                                                          87      0      6      1    99%
tests/test_termcolor.py                                                                                         47      0      0      0   100%
----------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                         4083    400    718     71    88%

================================================================================== short test summary info ==================================================================================
SKIPPED [1] tests/test_json.py:1232: torch is not installed
SKIPPED [1] tests/test_json.py:1239: pydantic is not installed
SKIPPED [1] tests/test_json.py:1249: pint is not installed
SKIPPED [1] tests/test_json.py:1257: bson not present
SKIPPED [1] tests/test_json.py:751: bson not present
SKIPPED [1] tests/test_json.py:928: bson not present
SKIPPED [1] tests/test_json.py:676: pint not present
SKIPPED [1] tests/test_json.py:979: pydantic not present
SKIPPED [1] tests/test_json.py:497: torch not present
============================================================== 2 failed, 193 passed, 9 skipped, 9 warnings in 83.57s (0:01:23) ==============================================================

Code snippet

No response

Log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@yurivict yurivict added the bug label Jan 6, 2025
@DanielYang59
Copy link
Contributor

Hi @yurivict monty tests require several optional dependencies in order to run the complete test suite:

monty/pyproject.toml

Lines 27 to 55 in 35ffd2d

[project.optional-dependencies]
ci = [
"coverage",
"monty[optional]",
"pytest>=8",
"pytest-cov>=4",
"types-requests",
"pymongo"
]
# dev is for "dev" module, not for development
dev = ["ipython"]
docs = [
"sphinx",
"sphinx_rtd_theme",
]
json = [
"pymongo",
"orjson>=3.6.1",
"pandas",
"pydantic",
# https://github.com/hgrecco/pint/issues/2065
"pint; python_version<'3.13'",
# Note: need torch>=2.3.0 for numpy 2 # 719
"torch; python_version<'3.13'", # python 3.13 not supported yet
]
multiprocessing = ["tqdm"]
optional = ["monty[dev,json,multiprocessing,serialization]"]
serialization = ["msgpack"]
task = ["requests", "invoke"]

You might want to install monty with pip install -e .[ci] or pip install .[ci] (when you prefer not to install in editable mode).

Admittedly it's better to skip that particular test instead of throwing an error, I would fix it soon

@DanielYang59 DanielYang59 linked a pull request Jan 18, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
2 participants
@yurivict @DanielYang59