Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement adding new records #197

Closed
kgodey opened this issue Jun 7, 2021 · 2 comments · Fixed by #671
Closed

Implement adding new records #197

kgodey opened this issue Jun 7, 2021 · 2 comments · Fixed by #671
Assignees
Labels
work: frontend Related to frontend code in the mathesar_ui directory

Comments

@kgodey
Copy link
Contributor

kgodey commented Jun 7, 2021

Problem

The user should be able to add new records to a table.

Proposed solution

We should support this in the frontend. See the design issue.

Additional context

Record addition will use POST requests to /api/v0/records/

Blocked by design work in #193.

@kgodey kgodey added type: enhancement work: frontend Related to frontend code in the mathesar_ui directory needs: unblocking Blocked by other work labels Jun 7, 2021
@kgodey kgodey added this to the Editable Tables milestone Jun 7, 2021
@kgodey kgodey changed the title Implementing adding new records Implement adding new records Jun 7, 2021
@kgodey kgodey added ready Ready for implementation and removed needs: unblocking Blocked by other work labels Jul 20, 2021
@pavish pavish mentioned this issue Jul 28, 2021
7 tasks
@pavish
Copy link
Member

pavish commented Jul 28, 2021

These comment from @zackkrida from #492 (review) on locking other operations and showing save status, will be handled as part of this issue.

There should be some kind of UI lock while a deletion is in progress. Currently many operations can be performed during a delete, which could be problematic in the future once row editing, creating, etc. are avaliable

  • The delete button should be disabled while a delete operation is in progress. If I throttle my network to a slow connection, I'm able to press the delete button while a deletion is in-progress, which sends the same DELETE requests again.
  • Currently, I can change sort order while a large (I tried 20 and 100 rows) delete is in progress. This removes the red background from the rows being deleted and still performs the sort.

Confirmation on completion of deletion with a toast or other flash message would be ideal. It can be hard to tell just from the rows disappearing.
Currently no error handling if a delete request fails (simulated by blocking the delete endpoint):

@pavish pavish mentioned this issue Sep 19, 2021
17 tasks
@pavish
Copy link
Member

pavish commented Sep 22, 2021

There should be some kind of UI lock while a deletion is in progress. Currently many operations can be performed during a delete, which could be problematic in the future once row editing, creating, etc. are avaliable
Confirmation on completion of deletion with a toast or other flash message would be ideal. It can be hard to tell just from the rows disappearing.

These operations require detailed UX definitions, which are beyond the scope of this issue. I will create a new issue for them.

@kgodey kgodey added status: started work: frontend Related to frontend code in the mathesar_ui directory and removed type: enhancement work: frontend Related to frontend code in the mathesar_ui directory ready Ready for implementation labels Oct 12, 2021
Repository owner moved this from Started to Done in [NO LONGER USED] Mathesar work tracker Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
work: frontend Related to frontend code in the mathesar_ui directory
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants