Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add empty state messages in breadcrumb selectors #4099

Closed
pavish opened this issue Dec 24, 2024 · 4 comments · Fixed by #4101
Closed

Add empty state messages in breadcrumb selectors #4099

pavish opened this issue Dec 24, 2024 · 4 comments · Fixed by #4101
Labels
good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this ready Ready for implementation work: frontend Related to frontend code in the mathesar_ui directory
Milestone
Backlog

Comments

@pavish
Copy link
Member

pavish commented Dec 24, 2024

Description

  • Before Improve nav header behavior #4072, the navigation header was inconsistent among pages as described in Make navigation header behave more consistently #3287.
  • Previously the navigation then did not include item selectors of children. eg., if you are on the schemas page, there is no selector after it on the header to select tables.
  • Now, we have an item selector on the header for child entities.
  • There is currently no empty state when child entities are not present.
  • Open the application for the first time with no databases and click on the dropdown selector next to the logo:
    • Screenshot 2024-12-24 at 2 17 50 PM
  • Open a schema with no tables and click the dropdown
    • Screenshot 2024-12-24 at 2 19 07 PM

Expected behavior

  • Database selector:
    • When there are no databases, we should display a "No Databases configured" text in the dropdown.
    • We should display a peristent link to "Connect a database".
  • Schema selector:
    • When there are no schemas, we should display a "No Schemas configured" text in the dropdown. (The public schema can be deleted)
  • Table selector:
    • When there are no tables, we should display a "No Tables configured" text in the dropdown.
@pavish pavish added type: bug work: frontend Related to frontend code in the mathesar_ui directory beta: needs discussion Temporary label to mark issues that need discussion labels Dec 24, 2024
@pavish pavish changed the title Add empty state messages in breadcrumb items Add empty state messages in breadcrumb selectors Dec 24, 2024
@pavish pavish added good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this and removed beta: needs discussion Temporary label to mark issues that need discussion labels Dec 24, 2024
@pavish pavish added the ready Ready for implementation label Dec 24, 2024
@ShailRT
Copy link
Contributor

ShailRT commented Dec 24, 2024

can i work on this issue?

@ShailRT
Copy link
Contributor

ShailRT commented Dec 24, 2024

list-search
is something like this acceptable?

@sharath-1517
Copy link
Contributor

list-search is something like this acceptable?

Hey @ShailRT, you can make all those needed changes same like this in those three sections that Pavish has mentioned and then make a PR for it. Since it's Christmas and the New Years coming up they'll not be able to get back to you as fast as they always do. So make sure you make those changes, make a PR and wait and relax :) Rest assured! Thanks...

@ShailRT
Copy link
Contributor

ShailRT commented Dec 25, 2024

@sharath-1517 okay sure

@ShailRT ShailRT mentioned this issue Dec 29, 2024
Merged
7 tasks
ShailRT added a commit to ShailRT/mathesar that referenced this issue Jan 4, 2025
@ShailRT
Merge branch 'develop' into fix-mathesar-foundation#4099
9189da9
ShailRT added a commit to ShailRT/mathesar that referenced this issue Jan 6, 2025
@ShailRT
Merge branch 'develop' into fix-mathesar-foundation#4099
5290c38
seancolsen added a commit to ShailRT/mathesar that referenced this issue Jan 8, 2025
@seancolsen
Merge branch 'develop' into fix-mathesar-foundation#4099
1e36880
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this ready Ready for implementation work: frontend Related to frontend code in the mathesar_ui directory
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Added empty state messages in breadcrumb selectors (Header) ShailRT/mathesar
3 participants
@pavish @ShailRT @sharath-1517